From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [170.10.133.74]) by sourceware.org (Postfix) with ESMTPS id B06113858D3C for ; Thu, 5 May 2022 20:31:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B06113858D3C Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-30-Qhfx7P4ANuOaZzcVqK7suA-1; Thu, 05 May 2022 16:31:30 -0400 X-MC-Unique: Qhfx7P4ANuOaZzcVqK7suA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BA900803789; Thu, 5 May 2022 20:31:29 +0000 (UTC) Received: from [10.2.17.61] (unknown [10.2.17.61]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 78787C52C81; Thu, 5 May 2022 20:31:29 +0000 (UTC) Message-ID: <23464c69-1958-38ba-b4fb-3cd6c70a0e23@redhat.com> Date: Thu, 5 May 2022 13:31:28 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH 1/3] Fix "b f(std::string)", always use DMGL_VERBOSE To: Pedro Alves , gdb-patches@sourceware.org References: <20220505185020.3648774-1-pedro@palves.net> <20220505185020.3648774-2-pedro@palves.net> From: Keith Seitz In-Reply-To: <20220505185020.3648774-2-pedro@palves.net> X-Scanned-By: MIMEDefang 2.85 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 May 2022 20:31:32 -0000 On 5/5/22 11:50, Pedro Alves wrote: > Currently, on any remotely modern GNU/Linux system, > gdb.cp/no-dmgl-verbose.exp fails like so: [snip] What an amazingly complete history of this. Thank you! > Change-Id: Ib54fab4cf0fd307bfd55bf1dd5056830096a653b > --- > gdb/cp-name-parser.y | 5 +- > gdb/cp-support.c | 44 +++++--- > gdb/cp-support.h | 12 ++ > ...-dmgl-verbose.cc => break-f-std-string.cc} | 0 > gdb/testsuite/gdb.cp/break-f-std-string.exp | 105 ++++++++++++++++++ > gdb/testsuite/gdb.cp/no-dmgl-verbose.exp | 35 ------ > 6 files changed, 147 insertions(+), 54 deletions(-) > rename gdb/testsuite/gdb.cp/{no-dmgl-verbose.cc => break-f-std-string.cc} (100%) > create mode 100644 gdb/testsuite/gdb.cp/break-f-std-string.exp > delete mode 100644 gdb/testsuite/gdb.cp/no-dmgl-verbose.exp I see nothing to make me pause. I think you should approve your patch. Keith