Re: [PATCH 2/2] gdb: Add support for DW_LNS_set_prologue_end in line-table

[Lancelot SIX <Lancelot.Six@amd.com>]

Hi,

Thanks for the feedbacks.  I have done the changes locally (see below).

>>
>> +* GDB now honours the DWARF prologue_end line-table entry flag the compiler can
>> +  emit to indicate where a breakpoint should be placed to break in a function
>> +  past its prologue.
> 
> Should we tell what user-visible effects will this have?

Yes, probably.  Sorry, I am usually unsure to what extent maint commands 
are documented / mentioned in NEWS entries.

I have added the following locally on top of the original patch:

diff --git a/gdb/NEWS b/gdb/NEWS 

index 89811219f59..ca3c2d13629 100644 

--- a/gdb/NEWS 

+++ b/gdb/NEWS 

@@ -127,6 +127,11 @@ show ada source-charset 

    values for this follow the values that can be passed to the GNAT 

    compiler via the '-gnati' option.  The default is ISO-8859-1. 

 

+maintenance info line-table 

+  Add a PROLOGUE-END column to the output which indicates that an 

+  entry corresponds to an address where a breakpoint should be placed 

+  to be at the first instruction past a function's prologue. 

+ 

  * Changed commands 

 

  print 



> 
> IS-STMT and PROLOGUE-END should be in @samp, not @var.  Those are
> literal headings of the columns, so @var is inappropriate for them.
> 
> Thanks

I did the changes locally.

I'll include those change in a V2, but will wait for other reviews on 
the patches before sending it.

Thanks,
Lancelot.