From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2073.outbound.protection.outlook.com [40.107.104.73]) by sourceware.org (Postfix) with ESMTPS id 44CAB3858D38 for ; Tue, 21 Nov 2023 13:57:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 44CAB3858D38 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 44CAB3858D38 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.104.73 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1700575042; cv=pass; b=K0t+/d5O75loVbx07UxA/8BDhdFGn5Ym1Y2AodD5mSA/UYFn9CDDiH4xp8Nz9itl40RnCoeEJnezOmO+DjtT+JmZf3Zxtz9kmfeQIlKvXY/Mpx37szh3xK/vuAGr9TRQsDasZ31p3/2p/VzFhsRZ990YXgvu0R3U3DqNmXJjrg8= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1700575042; c=relaxed/simple; bh=W5uSbYASSOogVqayyYVzLCF5hsUzkSa0Eu0tOnA9A8w=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=fUZQYW3HNPm/ey7cA7K+Khp6uHoJJA68fStzKirODX7q5S4Zr2S2hQQ4LwLuxezoi7KU7ZVzvMavGAVsrbSqFGhREKDvxwePricxW6VEGLZGkRXXQWp7IR6EbXk3UtZ9bnUf3lB6D6psurtn7ZEPO+IcVfgoDWSEMSWb+z1O+J0= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=NsWe1T8kDeAxw+jqfQyoYDA/CYHOfyoxTR+2iCQxvqq0vMibGkKSXA2StDbG5zy+Z8gCqKHy6qTMRrHNxMjov1n7MSBrUoxxMwulnZxvOQifFw4hY1nABJOc6phMkSyG9dP9hi64JNrMSBcKTewsF27pM3LIEnII8Kyz1C8SE9WFIzuI1nJo127lfkpEp/YUFX7IrlEmA283/FmxuXeys6+QeHosB213CvCaN3g0VvTz98EfPJfsXi5GPrVTKR/hRk4NUmhXTAAxUPAGeCtha0bfe8hgkE9hX0YxKp4B6K/tT0yX48ose9EVrmxBNu0oCaefxqPaCkor0UiMBrKYoQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZGY8eswfFsLOVCpR9bxVHOoJUUkhSIx60b9ZIjT18Y0=; b=RLebbdex/CAXIh1FM3BiUtKfQZkbTWt4x2sNoZcDqMr+R895rz5/tkkFGAYVW5RngS7ux+Ksf1RaXn+tz/0BblC/XuEFwyizisISH4CRXQMArYICTU4KPumFjtOjyIXZyHooZTm1X99I+HNwL1jAQ62kKgoIai2eXjG4faIIZThUmaQNL4QtwcJsztTv+qWpTLBhw0zZSzoTLoK63b0GKglcgMD+A6K5Yro8XbGUPgYRxjQiv0YnOfLEKefWiSqhg9A6ffqBnKUuIJDy4a47cqf6J0JczGlTCWPAKcoBeWdACsMIznCpCwTjPcIsODXKuVIhpHPk8B336RcUT21bjg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZGY8eswfFsLOVCpR9bxVHOoJUUkhSIx60b9ZIjT18Y0=; b=jDVYcSjqY8rixNIC3HnF8+Dgd54eAE0nuOYxILsvjL7YG4uNn4NbS0dxlcBbw1JI9xq7CkVB17YfZXNUTFhdswGRpmXwM3GitqPqYw1V/0/WWGt1TF8O0lgLwFjcnoapikhDRdPlgByubh/hYneTTY3r8jq0rdk7ebZdRBw0D9o= Received: from DBBPR09CA0010.eurprd09.prod.outlook.com (2603:10a6:10:c0::22) by PAVPR08MB9305.eurprd08.prod.outlook.com (2603:10a6:102:306::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Tue, 21 Nov 2023 13:57:16 +0000 Received: from DU6PEPF00009524.eurprd02.prod.outlook.com (2603:10a6:10:c0:cafe::7f) by DBBPR09CA0010.outlook.office365.com (2603:10a6:10:c0::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28 via Frontend Transport; Tue, 21 Nov 2023 13:57:16 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DU6PEPF00009524.mail.protection.outlook.com (10.167.8.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.12 via Frontend Transport; Tue, 21 Nov 2023 13:57:16 +0000 Received: ("Tessian outbound e243565b0037:v228"); Tue, 21 Nov 2023 13:57:16 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: b82bbc78a969c849 X-CR-MTA-TID: 64aa7808 Received: from 8b53277888c5.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 246BB012-503D-4B68-936F-12566CE0067C.1; Tue, 21 Nov 2023 13:57:10 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 8b53277888c5.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 21 Nov 2023 13:57:10 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DsDCoCmrFsG5mi469WlbUR9RmxCOZ/s6cpmedsaUQMFfEfwl8+3ryzqz4mVO5BNXesGXJm6gPGnk8r+ONy96tbK79vAUdhG9p+T5fvhn2AD2EugmxhpuQzkm6NSFB/39RmL1JPKCHWaqAJ15JGrlqqtzafBy3DE7AKygBdxxckLgJW9amm7u+gC+rAoK01+P21ZYbzWO6u7/voj5WV6vgWCYP0oGdlXvaFeDEOnnKxxtnM6prxrNi0U7/3bIAKYVH3qJdBa4u6GcvQ2ISaSI7rr52ZgP+nVA1PnR7JF3aOPFfHu75tTFBafdSbra+a2+xidC080HDOJIlelMqFvrmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ZGY8eswfFsLOVCpR9bxVHOoJUUkhSIx60b9ZIjT18Y0=; b=JHl5I1nFM6we0nPtFsDFkRwBTvS40ntTHoVvt15GAMcX/XECGzHRIu8Tg3adr3xntm+0NYCjWJjxiqU5SMJwjUiqgNMyjZ3INVbZvlrGIhmKM394Oe0Dg1kDE3s3ARUgPoTV9ldOY1zGTYwsHibciFpquZ45g1/K9SR2m/8t3JR0KXZwrAjfXheDBCFNZj/T6QCEhC50P7JGESvCi2iVvosKIhKCWg7HzA7CDdSLEdsCw9rcHidHnvc/A7tD6TdrFUfjUyRVUMQ7LkMZudOKKSdoZCK8UX8tB0g9NBtAULnjpjYxOc/u0OqbF+NSsb0RrCNzmRmQo13XbkwoOeSGgQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZGY8eswfFsLOVCpR9bxVHOoJUUkhSIx60b9ZIjT18Y0=; b=jDVYcSjqY8rixNIC3HnF8+Dgd54eAE0nuOYxILsvjL7YG4uNn4NbS0dxlcBbw1JI9xq7CkVB17YfZXNUTFhdswGRpmXwM3GitqPqYw1V/0/WWGt1TF8O0lgLwFjcnoapikhDRdPlgByubh/hYneTTY3r8jq0rdk7ebZdRBw0D9o= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by PAWPR08MB9567.eurprd08.prod.outlook.com (2603:10a6:102:2f1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Tue, 21 Nov 2023 13:57:07 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e05e:c012:f1f9:eb51]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::e05e:c012:f1f9:eb51%4]) with mapi id 15.20.7002.027; Tue, 21 Nov 2023 13:57:07 +0000 Message-ID: <237d9e18-dae1-4ea2-a95d-05333899e2f6@arm.com> Date: Tue, 21 Nov 2023 13:57:01 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PING][PATCH v2] gdb/tdesc: Don't assign custom-group tdesc registers to 'general' Content-Language: en-US To: Ciaran Woodward , "gdb-patches@sourceware.org" Cc: "aburgess@redhat.com" References: <20230907170752.28639-1-ciaranwoodward@xmos.com> <20230913114126.23101-1-ciaranwoodward@xmos.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0070.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2af::10) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|PAWPR08MB9567:EE_|DU6PEPF00009524:EE_|PAVPR08MB9305:EE_ X-MS-Office365-Filtering-Correlation-Id: 8aa15fa6-2c60-4181-aeba-08dbea99c555 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: xx9CSSkHat2rjayspMgKTSr3TbN7/DRAfe3y8PSQNd0xlSZHrXUx07kX0Kw7aZB9DCgMVLj72u0Lr6ZrYM3CoqSR/JaJ6gMsmW2Ma+OJmozRLCWe1KIfPw+8DQgmjZd3p/8pSXFOoFgHY3xYmgVY7jRL9ueXy7arduJKgZPTJO1DsQsvi5zC0n9qTv31nBq+Vg7FFL5loV3DdD5iK3lX59tBG1dwvwCJ/PfICDdcx6FqlYp3AhetIdUVxLf5247a203k2EWExsGl+Fu+h1RWjhUZpwgZ4DAmLZ+GNSwEXqjf8I0/KBYk28yKsEpAmaSOOlvFeVK+L/2z8L2YdPWZGHccx5YjneHREyuTmvgJ6LfWVwhP7BAYUOgulMssI1xygZ8vWJusphcmX6BxGD8Q/m7a3RKZSgPN/17vCQhfz35J2CbJZ78qlPKAYimk0daigFoSUTUp5+6NflKsCVQCF827T6NW7d/0HQespeeXA7L6eeNQptBq0VPbH6QCL9eTA1an81C7OJYb8Dr2No+dqvoAJwVUCL+nULe0RC3uaV/KfOoL5+63LkuCoSaGWZ8DpLVSvWnFsGJc87DqydN2ZCXddspz9FMumoM+kKLh33/dhK2KuVOs/jqDS/nRr7magFFhPPfouIpN/LixRuupAg== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(396003)(136003)(39860400002)(376002)(366004)(346002)(230922051799003)(1800799012)(186009)(64100799003)(451199024)(5660300002)(44832011)(2906002)(41300700001)(4326008)(8936002)(8676002)(31686004)(66946007)(316002)(110136005)(66556008)(66476007)(86362001)(26005)(966005)(6486002)(478600001)(6512007)(6666004)(36756003)(53546011)(6506007)(2616005)(83380400001)(38100700002)(31696002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9567 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU6PEPF00009524.eurprd02.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 57e8ff93-30ea-47de-13a5-08dbea99be6b X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s1Dj2NkcpCOMRxbyl/g5QbX2roFH+Q2l+ftmKG6lfqms+jdENa6mqmPcVPmAXSm6lDHvQR4Xv33NuS5vXHVc1l4TCkWaImctSVCFlwTnfbnRbMZCjCD6thXjh9fT9hvGwsEOPrjnwmmSp4uJPADrR/ytrYSsOOpEqfGM2yVSAF5h9Wso4Z7Hh8pHzdd8VaB1wSxHbkvnAc5AYHZV6Mbral7e2HQe1Tp6co1bV7N2nBRxEEdozUYXTk0aXM08RAsgVCGLnIrrSbkchLW9LBuk2Rcd3wk3gBrVNTUV5DpJUqtODg8JgranRjs5ruIY9dAoevpQCNhNoMKcsVspFJe2SDFFVLOExHmE487aN2m95C10Bt91eXtymoYQDfSlEraroFH5BshfI1MQJgdU7c3jQNwSVkllYmuLIWkl7xHGYCPJB8Vdbm4qa+1zSmZoZmDdrt/XrjdTiZAUQtt8x8cpHna4LRey0vembrhvyPoTyLs06oVj/D7tNcRN17XiIIQlkXNawM9HdCviIEketzRHi7xOjVzpUlcwerXVRIEF1m97dBEN9y+muYFUozTwNyB3NWG40EEeOOvjsJ91L3lVqOWIeDOJ1PsnyetwMkSOePhmLz5WHyiwGhjH5xOvUNdG+/cjW47fxozxtRZmV1zFLzINwZ1OuDyNKdMw3MRkgbyv1o08LQyicJTA2mnbttrx2PIe1z8cJaKezl5ADbHv7oIqawbfbaC/zliPapTjC5pUl3dAzVjAor5fHL3QrDmUG3VLCzA4kxp0zn/LjBkDkg== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230031)(4636009)(136003)(396003)(39860400002)(346002)(376002)(230922051799003)(1800799012)(82310400011)(64100799003)(451199024)(186009)(36840700001)(40470700004)(46966006)(316002)(40480700001)(110136005)(107886003)(2616005)(26005)(336012)(41300700001)(81166007)(70586007)(70206006)(478600001)(356005)(6506007)(6512007)(83380400001)(53546011)(966005)(6486002)(44832011)(31686004)(47076005)(6666004)(8936002)(8676002)(4326008)(36860700001)(2906002)(5660300002)(36756003)(40460700003)(86362001)(82740400003)(31696002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2023 13:57:16.4679 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8aa15fa6-2c60-4181-aeba-08dbea99c555 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DU6PEPF00009524.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAVPR08MB9305 X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GIT_PATCH_0,KAM_DMARC_NONE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/20/23 13:25, Ciaran Woodward wrote: > Ping > > Discussion of the V1 can be found here: https://patchwork.sourceware.org/project/gdb/patch/20230907170752.28639-1-ciaranwoodward@xmos.com/ > > From what I see, this change is complete & useful as-is, but opens the door for further useful work in future - to improve the tdesc XMLs. > Options 1 and 3 from the v1 discussion look reasonable to me. For 3 it would be nice to establish some kind of versioning info so gdb can handle the xml the right way, and enforce group information. Say, if group information is missing for a "v2" of the XML format, warn/error out. For 1, I think it would be nice to cleanup gdb's target descriptions and add group information explicitly, to prevent this from happening. in the future. >> -----Original Message----- >> From: Ciaran Woodward >> Sent: Wednesday, September 13, 2023 12:42 PM >> To: gdb-patches@sourceware.org >> Cc: luis.machado@arm.com; aburgess@redhat.com; Ciaran Woodward >> >> Subject: [PATCH v2] gdb/tdesc: Don't assign custom-group tdesc registers >> to 'general' >> >> The 'Target Description' mechanism in GDB enables the target to >> supply the full set of registers available on the system to gdb >> in an XML format. >> >> This format enables setting the 'group' of each register, such >> that they can be queried using the 'info registers ' >> mechanism. >> >> However prior to this change, even if a register was explicitly >> assigned to a group, it would still show up in the >> 'info registers general' report. This is unexpected, and also >> disagrees with the comment above the tdesc_register_in_reggroup_p >> function, which says that '-1' should be returned if the register >> group is not-known, not the register group is known, but differs. >> >> There was a previous change that did address this issue in >> aa66aac47b4dd38f9524ddb5546c08cc09930d37 >> but it also caused registers with *no* group in the target >> description to be removed from 'general', so it was reverted in >> 440cf44eb0f70830b8d8ac35289f84129c7a35c1 >> as that behaviour was used by some targets. >> >> The change in this commit enhances the usefulness of the tdesc >> 'group' attribute for adding system configuration registers, >> of which there may be hundreds - very inconvenient to request >> and print on every 'info registers' call. >> --- >> gdb/target-descriptions.c | 14 +++++++++----- >> 1 file changed, 9 insertions(+), 5 deletions(-) >> >> diff --git a/gdb/target-descriptions.c b/gdb/target-descriptions.c >> index cdedf88c793..6eb626b9c5a 100644 >> --- a/gdb/target-descriptions.c >> +++ b/gdb/target-descriptions.c >> @@ -954,13 +954,17 @@ tdesc_register_in_reggroup_p (struct gdbarch >> *gdbarch, int regno, >> { >> struct tdesc_reg *reg = tdesc_find_register (gdbarch, regno); >> >> - if (reg != NULL && !reg->group.empty () >> - && (reg->group == reggroup->name ())) >> + if (reg != NULL) >> + { >> + if (reggroup == all_reggroup) >> return 1; >> >> - if (reg != NULL >> - && (reggroup == save_reggroup || reggroup == restore_reggroup)) >> - return reg->save_restore; >> + if (reggroup == save_reggroup || reggroup == restore_reggroup) >> + return reg->save_restore; >> + >> + if (reg != NULL && !reg->group.empty ()) >> + return (reg->group == reggroup->name ()); >> + } >> >> return -1; >> } >> -- >> 2.25.1 >