From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94001 invoked by alias); 18 Apr 2018 02:10:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 93985 invoked by uid 89); 18 Apr 2018 02:10:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 18 Apr 2018 02:10:03 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id A28A91E17E; Tue, 17 Apr 2018 22:10:01 -0400 (EDT) Subject: Re: [PATCH v5 4/8] Add tdesc osabi and architecture functions To: Alan Hayward , gdb-patches@sourceware.org Cc: nd@arm.com References: <20180410143337.71768-1-alan.hayward@arm.com> <20180410143337.71768-5-alan.hayward@arm.com> From: Simon Marchi Message-ID: <238ddcb5-af90-5c38-fc01-bb407c4b31aa@simark.ca> Date: Wed, 18 Apr 2018 02:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180410143337.71768-5-alan.hayward@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-04/txt/msg00363.txt.bz2 Hi Alan, Just a nit: On 2018-04-10 10:33 AM, Alan Hayward wrote: > diff --git a/gdb/common/tdesc.h b/gdb/common/tdesc.h > index 7f4222b653..311341da0d 100644 > --- a/gdb/common/tdesc.h > +++ b/gdb/common/tdesc.h > @@ -297,9 +297,18 @@ target_desc *allocate_target_description (void); > void set_tdesc_architecture (target_desc *target_desc, > const char *name); > > +/* Return the architecture associated with this target description as a string, > + or NULL if no architecture was specified. */ > +const char *tdesc_architecture_name (const struct target_desc *target_desc); > + > /* Set TARGET_DESC's osabi by NAME. */ > void set_tdesc_osabi (target_desc *target_desc, const char *name); > > +/* Return the osabi associated with this target description as a string, > + or NULL if no osabi was specified. */ > +const char * > +tdesc_osabi_name (const struct target_desc *target_desc); Remove the \n before the function name. Simon