From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2084.outbound.protection.outlook.com [40.107.22.84]) by sourceware.org (Postfix) with ESMTPS id B0051382EF10 for ; Mon, 19 Dec 2022 10:46:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0051382EF10 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LlUhAuWg2XQ/a5xGPLsvPAoyoub3rMJaXsdwu3HdD40=; b=afItmHG93+CojWQi1yFW6eaXpSkWPHz2oqOHQkrn4gajlguKw9BmsAzI7qXsLheyGc7cAy8r5P/mp3lmpzbJgrriBuVB3pWwS6ami1iL6fnNAkPQUCCI93MliCMmTXw3mKfqKvbL3Hq3lQMozxuHhgl3ZFUzyGxw71buyWa2MQA= Received: from DB7PR03CA0084.eurprd03.prod.outlook.com (2603:10a6:10:72::25) by AM8PR08MB6562.eurprd08.prod.outlook.com (2603:10a6:20b:355::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6; Mon, 19 Dec 2022 10:46:48 +0000 Received: from DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com (2603:10a6:10:72:cafe::e6) by DB7PR03CA0084.outlook.office365.com (2603:10a6:10:72::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.20 via Frontend Transport; Mon, 19 Dec 2022 10:46:48 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by DBAEUR03FT006.mail.protection.outlook.com (100.127.142.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5924.16 via Frontend Transport; Mon, 19 Dec 2022 10:46:48 +0000 Received: ("Tessian outbound b1d3ffe56e73:v132"); Mon, 19 Dec 2022 10:46:48 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: d9d963f04760b83a X-CR-MTA-TID: 64aa7808 Received: from c6dc7c06c239.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 29AD359D-3547-4F01-9192-F8B49EBB1324.1; Mon, 19 Dec 2022 10:46:42 +0000 Received: from EUR04-DB3-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id c6dc7c06c239.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 19 Dec 2022 10:46:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=H8tcCPEvMBobAESDZQEYViOwCBdRVEQjKVRGcXWeaF7+zbixAkYFk8JF1c6KYBW8530ysh+Mpa5ui6YMknvIO7s/dNbOAetdwfIQPdywYvjhGzpzTzTE+GbTNoW9NDt+yFNtxZdficJhk4eLlUGLN0VZ90r5sjuAbCb/eucOFcNZbMwJ7GOIvQh3WZZ8ZQaVvX7nyVwwOknCDGjy282XL7MZhua3jLGCnkZGf4RoeRj8NfnKRYVDOzqMeUPCidvCgCfuCZmAVR4jHNBcs5uGnf3nl8oVqsr3cy5N2aAER3qiqQdNn2paDkuirgp+Yr3xRb8pEkNGRihVGcFLYgmY+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LlUhAuWg2XQ/a5xGPLsvPAoyoub3rMJaXsdwu3HdD40=; b=gaU5Nm+07lE+pm7BU/QCefnaLDKL/hL3KGUlX4EQrdjIjb93u/RGdsCMEiXLisekKZuZxX/WmFQh59sNrjjrkJtEiOp+gQVno9te04sH/7QezOxedwzNKRhqPGOUSyjhidvyY7F/tsNjBcSYuN2n71Y4fPSG7wu/8gX4JyjTRH9YrsylFEdwwik/2Vcql2iUcOFL1QYVXG/InmiuCZy4TgWaEnbY7VeAh5F9wjZOPeLK9ZeMyZI5xXh5F1dbTvl7vwDYnDnJisv1InODNJdSHf/r2AnQXD+H/qggqbOL87Wb3dN+PLwFHnYgwtBXCbYTrvZc+iDkxcdGXX95vWJMUA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LlUhAuWg2XQ/a5xGPLsvPAoyoub3rMJaXsdwu3HdD40=; b=afItmHG93+CojWQi1yFW6eaXpSkWPHz2oqOHQkrn4gajlguKw9BmsAzI7qXsLheyGc7cAy8r5P/mp3lmpzbJgrriBuVB3pWwS6ami1iL6fnNAkPQUCCI93MliCMmTXw3mKfqKvbL3Hq3lQMozxuHhgl3ZFUzyGxw71buyWa2MQA= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS2PR08MB9319.eurprd08.prod.outlook.com (2603:10a6:20b:599::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.6; Mon, 19 Dec 2022 10:46:35 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::eed7:25a3:e4ea:187a%7]) with mapi id 15.20.5944.006; Mon, 19 Dec 2022 10:46:35 +0000 Message-ID: <23a22595-1979-d678-afb8-25b2300dd587@arm.com> Date: Mon, 19 Dec 2022 10:46:36 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH 26/46] Use require is_aarch32_target Content-Language: en-US To: Tom Tromey , gdb-patches@sourceware.org References: <20221217000818.3729389-1-tom@tromey.com> <20221217000818.3729389-27-tom@tromey.com> From: Luis Machado In-Reply-To: <20221217000818.3729389-27-tom@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P265CA0195.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:318::12) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS2PR08MB9319:EE_|DBAEUR03FT006:EE_|AM8PR08MB6562:EE_ X-MS-Office365-Filtering-Correlation-Id: ccf73149-e8d7-415a-9ed7-08dae1ae54a8 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: ufpS1SJ+FEjHF41SAg2Y1BPOyTkYYJVNGL6znTGqo2W19ZvReYuIZnRiGeZzSAoiCdTyNB/3auuBXH5x6OhsbXO6RzjrVZhb+dOdrPtEq/aM6dASivnSogx2t76cJkNY+Cb9mqe+3tBB4hCQ3m0m0bLsELFvWWyDIKPRre20jqICQ6pFBJhbRozS9ANAQ/C7Lv+HpbBuTd0FIjpM7q2QuJxpsMSRJ/ZMwVn9SRJSc/RXrkwc/goeT3lFcHnnVIf96qnAH7FAa+TJy1Bt/db0OrdFp+gEtXk86bwPUhQYsYskssOTwOn0Sjul86Ki0sFQPVNmHDlYETKs2AlEOhnDeIiCp1H78OzdvamFMptdVK7AUeO6Q16YBQ+ns4RbLpF57Zjx8xjKBDgpAjPcS9omBYR+jCsDZw4KQmdXGCgdFTy3djQPYXOZwRyhO7wICBdkJlLSt90X+U2paLCmIgNJzSRrFGrssFMQKyUYQld7RHsGZbgy6edrIi/BbSZaix1XvaXYmdkpnZMs+9Rmka6b57ag8IHjoi3c5iBfKNRcsYXuYUm3Xts9jEQfr8cTwlj658TMXYWdmCSAPvo9aGGA6lowMvAuio4B9a5JsWZLCOODNPULdgrzSnmMyVeuReFuCKwVFyi/yUoVon0Gd/szOnb2jp3Y3X7sqAcSTk2SYGDXTn+f14IMwzXyBXK2gLueFue8nRRWW4DrLjSUSfzLQy0Psrj58CR1R96P3vk9o/OSPVmCR9esqSVmF4lRXLTv X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(396003)(39860400002)(346002)(366004)(136003)(451199015)(36756003)(66946007)(86362001)(31696002)(44832011)(5660300002)(8936002)(38100700002)(316002)(26005)(186003)(66556008)(2616005)(31686004)(478600001)(6486002)(2906002)(8676002)(41300700001)(66476007)(6512007)(53546011)(83380400001)(6506007)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS2PR08MB9319 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 8e4b344a-7047-4d45-56fd-08dae1ae4c9a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: lzxwbk6bQyKtTBh+vesBxCH+H0RX4WL5vTAN5DGWKiUiXe2EKVowI71ERaAjGKqI0QJg3InAjNjbbWneojYkbahj8RskOximqouN4EwNscQ6PGdsLsh/juLZ+U0kDVGot6Z4mltzufDgJDjutSqMup3skGf6NgER7CV7QEEFFDsWj843Pa+CNO/EUYLelRd4jFdWsWhPYy7Ug/61z9Dkzb9InRY/wsB2VCgZwNIcDkzQKpDp8RQTS7arbiLeXo6aVSVpbcqds3wYQpHSO6M3QYyNkBHeaMKllYAkCG8gfjpNYyzS0JDNdQVEdGdfOuDJ+HdKBwiBRk0wU7WKCPq0Q+579vh1ovUeOH8L3ttOlwkV1YP3nAO63BUxL1ZEIkEzir8DSaLDWWbNwfarGl4OHyGt/z6x4S8cjJchRPFJexJXJbLogapbBFseAzkBpGQOymzDrsMK0IicCAGwd/IOe6SvbvEESE1JXzbpUAOaTG/fmh47wtEIMiQuXFbt1c0gnhXQ1R90ZyL7Hm2wTK7NvDAC7ROaQXDUOso55xpNZraAVwbDaF2tjSXH8qhejLrLehtTeFBVkGTvt2Aek68WkG3ZH5ihlMsV50kXo48hWUmlbMpakTpnUvBfWQvfsyX4wmwjlx50mvBG2mR2sFw9n3M8lhbGNbNpkO8XFJtzg1janpBFx8yuLN5fWQoe6lD3TNFUH3QvI60wvc6ZKdGjNxCENGF8vcEURaZ8cn1QW8DxdisoG8AazAm9x/YoZ98hiYmv2Swp/tAye9n4zoqVVw== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(346002)(39860400002)(396003)(376002)(136003)(451199015)(36840700001)(40470700004)(46966006)(31696002)(2616005)(6506007)(53546011)(336012)(26005)(186003)(82740400003)(6512007)(356005)(81166007)(86362001)(478600001)(36756003)(6486002)(47076005)(31686004)(8936002)(41300700001)(82310400005)(2906002)(40460700003)(83380400001)(40480700001)(316002)(36860700001)(5660300002)(8676002)(70586007)(70206006)(44832011)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Dec 2022 10:46:48.7242 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ccf73149-e8d7-415a-9ed7-08dae1ae54a8 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: DBAEUR03FT006.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6562 X-Spam-Status: No, score=-12.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/17/22 00:07, Tom Tromey wrote: > This changes some tests to use "require is_aarch32_target". > --- > gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp | 5 +---- > gdb/testsuite/gdb.arch/arm-disp-step.exp | 5 +---- > gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp | 5 +---- > gdb/testsuite/gdb.arch/pr25124.exp | 5 +---- > gdb/testsuite/gdb.arch/thumb-bx-pc.exp | 5 +---- > gdb/testsuite/gdb.arch/thumb-prologue.exp | 5 +---- > gdb/testsuite/gdb.arch/thumb-singlestep.exp | 5 +---- > 7 files changed, 7 insertions(+), 28 deletions(-) > > diff --git a/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp b/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp > index 34d98aec96e..37710649005 100644 > --- a/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp > +++ b/gdb/testsuite/gdb.arch/arm-bl-branch-dest.exp > @@ -13,10 +13,7 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see . > > -if { ![is_aarch32_target] } { > - verbose "Skipping ${gdb_test_file_name}." > - return > -} > +require is_aarch32_target > > standard_testfile > > diff --git a/gdb/testsuite/gdb.arch/arm-disp-step.exp b/gdb/testsuite/gdb.arch/arm-disp-step.exp > index ec6578257b3..0eb1707bb6c 100644 > --- a/gdb/testsuite/gdb.arch/arm-disp-step.exp > +++ b/gdb/testsuite/gdb.arch/arm-disp-step.exp > @@ -17,10 +17,7 @@ > > # Test arm displaced stepping. > > -if {![is_aarch32_target]} { > - verbose "Skipping arm displaced stepping tests." > - return > -} > +require is_aarch32_target > > standard_testfile .S > > diff --git a/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp b/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp > index c3544b16a0b..22a2559b271 100644 > --- a/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp > +++ b/gdb/testsuite/gdb.arch/arm-single-step-kernel-helper.exp > @@ -13,10 +13,7 @@ > # You should have received a copy of the GNU General Public License > # along with this program. If not, see . > > -if { ![is_aarch32_target] } { > - verbose "Skipping ${gdb_test_file_name}." > - return > -} > +require is_aarch32_target > > standard_testfile > > diff --git a/gdb/testsuite/gdb.arch/pr25124.exp b/gdb/testsuite/gdb.arch/pr25124.exp > index a68a3d1b7df..95636bd1ed8 100644 > --- a/gdb/testsuite/gdb.arch/pr25124.exp > +++ b/gdb/testsuite/gdb.arch/pr25124.exp > @@ -16,10 +16,7 @@ > # Test proper disassembling of ARM thumb instructions when reloading a symbol > # file. > > -if {![is_aarch32_target]} { > - verbose "Skipping ARM tests." > - return > -} > +require is_aarch32_target > > standard_testfile .S > > diff --git a/gdb/testsuite/gdb.arch/thumb-bx-pc.exp b/gdb/testsuite/gdb.arch/thumb-bx-pc.exp > index ccc6fbfdca7..6989d79c6d6 100644 > --- a/gdb/testsuite/gdb.arch/thumb-bx-pc.exp > +++ b/gdb/testsuite/gdb.arch/thumb-bx-pc.exp > @@ -15,10 +15,7 @@ > > # Test PC adjustment from Thumb-mode "bx pc" instruction. > > -if {![is_aarch32_target]} { > - verbose "Skipping ARM tests." > - return > -} > +require is_aarch32_target > > set testfile "thumb-bx-pc" > set srcfile ${testfile}.S > diff --git a/gdb/testsuite/gdb.arch/thumb-prologue.exp b/gdb/testsuite/gdb.arch/thumb-prologue.exp > index 0cb14572345..8e83bd3c009 100644 > --- a/gdb/testsuite/gdb.arch/thumb-prologue.exp > +++ b/gdb/testsuite/gdb.arch/thumb-prologue.exp > @@ -15,10 +15,7 @@ > > # Test ARM/Thumb prologue analyzer. > > -if {![is_aarch32_target]} { > - verbose "Skipping ARM prologue tests." > - return > -} > +require is_aarch32_target > > standard_testfile > > diff --git a/gdb/testsuite/gdb.arch/thumb-singlestep.exp b/gdb/testsuite/gdb.arch/thumb-singlestep.exp > index 289bdf52463..c3b7999036e 100644 > --- a/gdb/testsuite/gdb.arch/thumb-singlestep.exp > +++ b/gdb/testsuite/gdb.arch/thumb-singlestep.exp > @@ -15,10 +15,7 @@ > > # Test single-stepping into incorrectly marked Thumb routine > > -if {![is_aarch32_target]} { > - verbose "Skipping ARM tests." > - return > -} > +require is_aarch32_target > > set testfile "thumb-singlestep" > set srcfile ${testfile}.S LGTM.