public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <pedro@palves.net>
To: Luis Machado <luis.machado@linaro.org>,
	Simon Marchi <simark@simark.ca>,
	gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't drop static function bp locations w/o debug info
Date: Thu, 24 Sep 2020 16:35:00 +0100	[thread overview]
Message-ID: <23b6b312-ddc8-cbc3-78b2-54cc099f9154@palves.net> (raw)
In-Reply-To: <28a2dbf2-d9dc-0ffe-8b45-fa36a3522b25@linaro.org>

On 9/24/20 4:32 PM, Luis Machado wrote:
> On 9/24/20 12:16 PM, Pedro Alves wrote:
> 
> It is the same case for AArch64. The reason for not skipping a prologue is because there doesn't seem to be one. The generated code for aarch64 is the following:
> 
> (gdb) disass foo
>    0x00000000000008bc <+0>:     nop
>    0x00000000000008c0 <+4>:     ret
> End of assembler dump.
> 
> I guess the assumptions of the test are valid for x86, but they're not valid for aarch64.
> 

OK.  So the

   -    "<foo\\+$decimal>"
   +    "<foo(\\+$decimal)?>"

fix should be all that's necessary.  Do you want to give it a try?

  reply	other threads:[~2020-09-24 15:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 19:21 Pedro Alves
2020-06-12 19:53 ` Simon Marchi
2020-09-13 13:25   ` Pedro Alves
2020-09-22 20:20     ` Luis Machado
2020-09-24 15:16       ` Pedro Alves
2020-09-24 15:32         ` Luis Machado
2020-09-24 15:35           ` Pedro Alves [this message]
2020-09-24 15:44             ` Luis Machado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23b6b312-ddc8-cbc3-78b2-54cc099f9154@palves.net \
    --to=pedro@palves.net \
    --cc=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=simark@simark.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).