From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by sourceware.org (Postfix) with ESMTPS id CEE283857C52 for ; Thu, 24 Sep 2020 15:35:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org CEE283857C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wm1-f67.google.com with SMTP id a9so4075889wmm.2 for ; Thu, 24 Sep 2020 08:35:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aAZaiDxVKyDA20MNSVtKVvsNau32JuJKZof1Jiw0hko=; b=it+vNwzI6cl5n1xL3kbs/hMu9jGNzEKF18RmznPKapxSSw+DuxZzWBn4gp2AFSkQFV XQS4XJAz1YqWW7lN+fJW/IuFCktkFnlLzQRHuT850e9KVcFSDJ7+EexJyrLxcUuJw72O 12gTjyl/KR93gGiQ/9GMV7Vr3EhenauutDME240YSBIuPvViiZ4/oxTxg5mVZdKaWl4d rLYzXNuV5hIpxvUFiTVIyWS2LhZcm2dkrhZZPYyAKF0HTkB5VEfz52/KpcF0vo+mqwwq FQhSrhqDM5+djrcX1L1i5QfagGsgpOHYntHAX8hXEkIaSAA7e1HN8dQN0r2YMqQL3vZl y5Mg== X-Gm-Message-State: AOAM532ZI34O7eC2RT9fptsDYH12Olh8LdNXB0Rcgq+aCopFzcNTatZH CN/Jaey3gV+TTP4IjPbRBkIjolcYAJCndA== X-Google-Smtp-Source: ABdhPJy6xJQYpKx5Io9gY5QH9aneBCy+2McCzij5EKHRpuEhK+MkOVPwdffwRFrVG+1p++5kmUQ/3Q== X-Received: by 2002:a1c:40a:: with SMTP id 10mr5526679wme.61.1600961703309; Thu, 24 Sep 2020 08:35:03 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:eefd:c63:53e0:3e8a? ([2001:8a0:f905:5600:eefd:c63:53e0:3e8a]) by smtp.gmail.com with ESMTPSA id e1sm4283093wrp.49.2020.09.24.08.35.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Sep 2020 08:35:02 -0700 (PDT) Subject: Re: [PATCH] Don't drop static function bp locations w/o debug info To: Luis Machado , Simon Marchi , gdb-patches@sourceware.org References: <20200612192108.11481-1-pedro@palves.net> <22959b69-54bd-012e-4026-feb4f02ac671@simark.ca> <5aea0e8a-2d19-3fa0-5281-86e41be4b8b9@palves.net> <1f254bd1-e75a-cdf3-e7c6-e89d51216635@linaro.org> <28a2dbf2-d9dc-0ffe-8b45-fa36a3522b25@linaro.org> From: Pedro Alves Message-ID: <23b6b312-ddc8-cbc3-78b2-54cc099f9154@palves.net> Date: Thu, 24 Sep 2020 16:35:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <28a2dbf2-d9dc-0ffe-8b45-fa36a3522b25@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00, BODY_8BITS, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Sep 2020 15:35:05 -0000 On 9/24/20 4:32 PM, Luis Machado wrote: > On 9/24/20 12:16 PM, Pedro Alves wrote: > > It is the same case for AArch64. The reason for not skipping a prologue is because there doesn't seem to be one. The generated code for aarch64 is the following: > > (gdb) disass foo >    0x00000000000008bc <+0>:     nop >    0x00000000000008c0 <+4>:     ret > End of assembler dump. > > I guess the assumptions of the test are valid for x86, but they're not valid for aarch64. > OK. So the - "" + "" fix should be all that's necessary. Do you want to give it a try?