From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 86E40385C310 for ; Thu, 30 Nov 2023 18:03:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 86E40385C310 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 86E40385C310 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701367418; cv=none; b=BczKeP0iTUHknIcROVOlHS5JuydlcUDpfjYyVWEny4q6Ql6U6/GBZMtervuueAV47o5c4pBopFY1QVJ2CepLXETkQIf82pE4/pD7KZvWhNQmTGe/mdD6MsLcS+Nrp8+sBvZX7rrUnw7NJ6wqYmB2VYpBObh8SoHZYr7e9ux/zBU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701367418; c=relaxed/simple; bh=eXFNLseDkDa/sEiX2WeZT5iCQCMkZXcHe0nxDV8VSS4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Le4NuS+upTjO7hhSHm48+/3GLiK2yP5rRicIVIy/nXG0B74l2dxExIdguMGJe2w/FAiqiwnctqP8Y7OMfdybVF5Py6yyS/58gmuRZiGBZsakfQ+2ImyV9RwsjWIQO5iGkhestPIutZYL4BHs6Jj4rKhrvRioU6DTul+Iouj9zbw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1701367417; bh=eXFNLseDkDa/sEiX2WeZT5iCQCMkZXcHe0nxDV8VSS4=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=oB0LBxmsJ2vAE89J3c4217VTTKeJQoLpN3FTDGnLuktjms9swDPf0dYPnnN3OFJR3 debevxfwI5Px5Z0kt9qf8ufLGMh78G2vyNSnObYUHP7TZj4KK5FLIMOb8ePfh6yOzO J2cGLtTxfaMV43siUUDfGfM/8WnlkoS5yrKuNKng= Received: from [172.16.0.106] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id AC1011E091; Thu, 30 Nov 2023 13:03:36 -0500 (EST) Message-ID: <23d042a3-7f2a-4af3-ab8b-0f43dc0f275e@simark.ca> Date: Thu, 30 Nov 2023 13:03:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/8] Use C++17 [[fallthrough]] attribute Content-Language: fr To: PATCH@sourceware.org, More@sourceware.org, gdb-patches@sourceware.org Cc: Tom Tromey , John Baldwin , Luis Machado , Pedro Alves References: <20231121152817.31859-1-tom@tromey.com> <20231121152817.31859-2-tom@tromey.com> From: Simon Marchi In-Reply-To: <20231121152817.31859-2-tom@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/21/23 10:27, Tom Tromey wrote: > This changes gdb to use the C++17 [[fallthrough]] attribute rather > than special comments. > > This was mostly done by script, but I neglected a few spellings and so > also fixed it up by hand. > > I suspect this fixes the bug mentioned below, by switching to a > standard approach that, presumably, clang supports. Are you able to test building on macos? I see this on my macos builder: /Users/jenkins/build/workspace/binutils-gdb_master_macosbuild/platform/macos-amd64/target_board/unix/src/binutils-gdb/gdb/dbxread.c:2809:7: error: fallthrough annotation does not directly precede switch label [[fallthrough]]; ^ Simon