From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 19CCB385803F for ; Thu, 13 Oct 2022 21:44:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 19CCB385803F Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 3947F1F895; Thu, 13 Oct 2022 21:44:21 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 20CB1139F3; Thu, 13 Oct 2022 21:44:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 8/Z7BrWGSGOqUgAAMHmgww (envelope-from ); Thu, 13 Oct 2022 21:44:21 +0000 Message-ID: <243a535f-e79a-c52c-f5f8-1b03d332b564@suse.de> Date: Thu, 13 Oct 2022 23:44:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH 0/2] Fix .gdb_index with Ada Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20220922202054.2773698-1-tromey@adacore.com> <03994f80-2aa9-e30a-2cab-d458b402e148@suse.de> <8735buqgh2.fsf@tromey.com> <871qrbpico.fsf@tromey.com> From: Tom de Vries In-Reply-To: <871qrbpico.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2022 21:44:23 -0000 On 10/13/22 22:40, Tom Tromey wrote: > Tom> [ ... patch ... ] > Tom> fixes the FAIL, so is this one of the "rare and not worth supporting" > Tom> cases you're referring to? > >> I thought that was necessary to avoid redundancy in the index, but I see >> now it isn't, or at least not in that way. I'm looking again at why the >> new indices are larger in general. > > I looked into this more. > > Older versions of gdb don't add C++ symbols to the index, so when I > diff'd the indexes I saw a lot of "_Z" additions. Locally I've changed > this code to skip linkage names for C++ only. > Ah, does that then fix the c-linkage-name.exp regression? Thanks, - Tom > I compared the symbols from old and new indexes. In every case (except > the one below) I checked, the new gdb seemed more correct. In > particular it added inlined functions to the index, and it used the > correct name for "enum class" enumerator constants. > > I did find out that the new index included entries for the linkage names > of classes. This isn't generally useful, and they have weird names like > "6mumble", so I also have a patch to drop these entries from the cooked > index entirely. > > Tom