From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17145 invoked by alias); 31 Aug 2017 16:35:22 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17136 invoked by uid 89); 31 Aug 2017 16:35:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=H*M:f4cc, learn X-HELO: aserp1040.oracle.com Received: from aserp1040.oracle.com (HELO aserp1040.oracle.com) (141.146.126.69) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 31 Aug 2017 16:35:12 +0000 Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v7VGZ8JF024672 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Aug 2017 16:35:08 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v7VGZ72l026848 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 31 Aug 2017 16:35:07 GMT Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v7VGZ7PQ011724; Thu, 31 Aug 2017 16:35:07 GMT Received: from [172.27.35.125] (/108.88.88.153) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 31 Aug 2017 09:35:07 -0700 Subject: Re: [PATCH v3] Unbreak gdb build on 32-bit host with ADI support To: Pedro Alves , gdb-patches@sourceware.org References: <1503707605-65627-1-git-send-email-weimin.pan@oracle.com> <321a5c87-893a-a176-cc4b-b13ba9dc5730@redhat.com> From: Wei-min Pan Message-ID: <24629416-9110-fc96-f4cc-954d9499247c@oracle.com> Date: Thu, 31 Aug 2017 16:35:00 -0000 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <321a5c87-893a-a176-cc4b-b13ba9dc5730@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00541.txt.bz2 HI Pedro, Thank you very much for your helpful suggestions/ideas. While I've learned quite a bit from the reviews on my first patch, I believe I have a long way to go :) Thanks again, Weimin On 8/31/2017 1:31 AM, Pedro Alves wrote: > Hi Weimin, > >> +2017-08-25 Weimin Pan >> + >> + * sparc64-tdep.c: Unbreak gdb build on 32-bit host with ADI support. >> + > In the GNU ChangeLog format, this should say which functions were touched, > and what was changed, as opposed to "why" things were changed. Please take a > look here to learn more about this: > > https://sourceware.org/gdb/wiki/ContributionChecklist > > You actually already had the right info in the commit log, so I cooked up > an entry for you, and pushed the patch in with that: > > 2017-08-31 Weimin Pan > > * sparc64-tdep.c (adi_stat_t): Fix comment formatting. > (adi_available): Use a temp variable of type CORE_ADDR as argument > 3 when calling target_auxv_search. > (adi_normalize_address): Use masks and xor operators to calculate > normalized address. > (adi_read_versions, adi_write_versions, adi_print_versions) > (do_examine, do_assign): Use paddress. > > Thanks for the patch. > > Pedro Alves >