From: John Baldwin <jhb@FreeBSD.org>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/2] Use unique_xmalloc_ptr in location.[ch]
Date: Tue, 12 Dec 2023 15:52:02 -0800 [thread overview]
Message-ID: <24924096-6467-42c7-a3d9-35dc225bc1ab@FreeBSD.org> (raw)
In-Reply-To: <20231210-location-stuff-v1-0-9b6ae74fe5b0@tromey.com>
On 12/10/23 7:20 AM, Tom Tromey wrote:
> This short series changes location.[ch] to use unique_xmalloc_ptr,
> removing some manual memory management.
>
> ---
> Tom Tromey (2):
> Use unique_xmalloc_ptr in linespec_location_spec
> Use unique_xmalloc_ptr in explicit_location_spec
>
> gdb/breakpoint.c | 14 ++++-----
> gdb/completer.c | 14 +++++----
> gdb/linespec.c | 76 +++++++++++++++++++++++++---------------------
> gdb/location.c | 43 ++++++++++----------------
> gdb/location.h | 28 ++++++++---------
> gdb/mi/mi-cmd-break.c | 6 ++--
> gdb/python/py-breakpoint.c | 12 ++++----
> 7 files changed, 95 insertions(+), 98 deletions(-)
> ---
> base-commit: eef4ff9b707d738322a5dca82a6a9b0aad76a26e
> change-id: 20231210-location-stuff-31339a1c6b45
>
> Best regards,
These both LGTM.
Reviewed-By: John Baldwin <jhb@FreeBSD.org>
--
John Baldwin
prev parent reply other threads:[~2023-12-12 23:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-10 15:20 Tom Tromey
2023-12-10 15:20 ` [PATCH 1/2] Use unique_xmalloc_ptr in linespec_location_spec Tom Tromey
2023-12-10 15:20 ` [PATCH 2/2] Use unique_xmalloc_ptr in explicit_location_spec Tom Tromey
2023-12-12 23:52 ` John Baldwin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24924096-6467-42c7-a3d9-35dc225bc1ab@FreeBSD.org \
--to=jhb@freebsd.org \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).