From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 7250C385C317 for ; Wed, 13 Dec 2023 08:25:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7250C385C317 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7250C385C317 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702455908; cv=none; b=XNYD76vYxacERfC8ww+MIT2hbiBe6JN+zAFJ1b1A5MfCrlLRPl6YHTw5tiPbLLJ/UGovMNCBTHDvx8UGwrVhLncEZU7f9uq6/b78ijRilgmAnBAczp7WiZdOdVZA5gbb4S+l7uzSei8zzTpMltSquVmyvhlMSXH4ToHbqspj7Eg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702455908; c=relaxed/simple; bh=V7MgVzi0wKxqifK/L0MgRGcu1fu5cHk9DpX6Wcvrm0c=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=ZX6rxx2fjHtHZQ2hT/hMPQIBujl3qquMiH7ljA752xzRsBmHzaPOE0R0zwiXYNal+CyQhHrEbVJTOjpaVUMn2z04/+v7RCc0onWA94xUxVDRkSNfL5wqG8zpbaSZt2WSfAjXatRuPMVXnlmA5IU1vLl18zW+H5ZDEEd/FdD+l6g= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 14F9422569; Wed, 13 Dec 2023 08:25:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702455904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dIC3ogplW2Cjpd3Nh8aPjgB5hHiaqSmg4C2JZNJ8jdE=; b=FDzl/2qpAQtTOx+tCnw1/Y2SZ41l6xbEIsHTucZjhv8V5LWtwkXvVYUE+tXGYjlsuuwUAi 1ztXd5v5zFxZNn7n5A5YSZDyHWQ4rnE6F8yDx6E3VSLONSMhk/SH/YVKBK43GCMR9VIgi/ JTLq6Pgt4axWD5COEQdB9fZqozZv+Qg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702455904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dIC3ogplW2Cjpd3Nh8aPjgB5hHiaqSmg4C2JZNJ8jdE=; b=crgutms1N9oP6IArRfVoAH65CAzSoQ8Rd3iX44UQnRWVzhj1p+YGE7l2Rdfu4AYhh1TeRv eVpWLnCx/KALErAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702455904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dIC3ogplW2Cjpd3Nh8aPjgB5hHiaqSmg4C2JZNJ8jdE=; b=FDzl/2qpAQtTOx+tCnw1/Y2SZ41l6xbEIsHTucZjhv8V5LWtwkXvVYUE+tXGYjlsuuwUAi 1ztXd5v5zFxZNn7n5A5YSZDyHWQ4rnE6F8yDx6E3VSLONSMhk/SH/YVKBK43GCMR9VIgi/ JTLq6Pgt4axWD5COEQdB9fZqozZv+Qg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702455904; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dIC3ogplW2Cjpd3Nh8aPjgB5hHiaqSmg4C2JZNJ8jdE=; b=crgutms1N9oP6IArRfVoAH65CAzSoQ8Rd3iX44UQnRWVzhj1p+YGE7l2Rdfu4AYhh1TeRv eVpWLnCx/KALErAA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id F1939137E8; Wed, 13 Dec 2023 08:25:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id x2uUOV9qeWV6MQAAD6G6ig (envelope-from ); Wed, 13 Dec 2023 08:25:03 +0000 Message-ID: <24abfba4-4d2f-4a81-b19c-0514fdf1d217@suse.de> Date: Wed, 13 Dec 2023 09:25:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 03/13] [gdb/symtab] Handle nullptr parent in parent_map::set_parent Content-Language: en-US To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20231212173239.16793-1-tdevries@suse.de> <20231212173239.16793-4-tdevries@suse.de> <87plzbclsu.fsf@tromey.com> From: Tom de Vries In-Reply-To: <87plzbclsu.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Level: ************* X-Spam-Score: 13.10 X-Spam-Level: Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b="FDzl/2qp"; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=crgutms1; dmarc=pass (policy=none) header.from=suse.de; spf=softfail (smtp-out1.suse.de: 2a07:de40:b281:104:10:150:64:97 is neither permitted nor denied by domain of tdevries@suse.de) smtp.mailfrom=tdevries@suse.de X-Rspamd-Server: rspamd2 X-Spamd-Result: default: False [-14.75 / 50.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; XM_UA_NO_VERSION(0.01)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all:c]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[suse.de:+]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(0.00)[suse.de,none]; MX_GOOD(-0.01)[]; DMARC_POLICY_ALLOW_WITH_FAILURES(-0.50)[]; NEURAL_HAM_SHORT(-0.20)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-2.25)[96.47%]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; DWL_DNSWL_HI(-3.50)[suse.de:dkim]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; WHITELIST_DMARC(-7.00)[suse.de:D:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:email]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_TLS_ALL(0.00)[] X-Spam-Score: -14.75 X-Rspamd-Queue-Id: 14F9422569 X-Spam-Flag: NO X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/12/23 19:34, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Set_parent uses m_die_range_map.set_empty, which doesn't allow > Tom> parent_entry == nullptr. > > Tom> So it may be necessary to guard calls to set_parent with > Tom> "if (parent_entry != nullptr)". > > Tom> Fix this by handling the parent_entry == nullptr case in set_parent. > > It seems like this must be a programming error somewhere? > Currently the only caller is guarded: > > if (parent_entry != nullptr) > ... > m_die_range_map.set_empty (start, end, (void *) parent_entry); Yes, and I've left that in place because I couldn't convince myself that this wouldn't introduce a performance regression, but perhaps it doesn't matter and we should drop the check there. I'm not sure why you say programming error. I know using addrmap::set_empty (..., nullptr) is a programming error. This patch attempts to make sure that using parent_map::set_parent (..., nullptr) is not a programming error. Anyway, this is needed for a set_parent added by "[gdb/symtab] Keep track of all parents for cooked index". Thanks, - Tom