From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14732 invoked by alias); 24 May 2018 12:53:23 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14719 invoked by uid 89); 24 May 2018 12:53:21 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Parts X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 24 May 2018 12:53:20 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w4OCrDJ5014126 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 24 May 2018 08:53:18 -0400 Received: by simark.ca (Postfix, from userid 112) id 825D71F21C; Thu, 24 May 2018 08:53:13 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 618C51EF61; Thu, 24 May 2018 08:53:12 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 24 May 2018 14:10:00 -0000 From: Simon Marchi To: Gary Benson Cc: gdb-patches@sourceware.org, Simon Marchi , Pedro Alves Subject: Re: [PATCH v2] linux: Add maintenance commands to test libthread_db In-Reply-To: <1527096776-29187-1-git-send-email-gbenson@redhat.com> References: <1511361761-1333-1-git-send-email-gbenson@redhat.com> <1527096776-29187-1-git-send-email-gbenson@redhat.com> Message-ID: <24cc63299f03c8616f081466041e9321@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 24 May 2018 12:53:13 +0000 X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00645.txt.bz2 On 2018-05-23 13:32, Gary Benson wrote: > Hi all, > > This is an updated version of a patch I submitted for review back in > November. It adds two new commands which may be used to test thread > debugging libraries used by GDB: > > * "maint check libthread-db" tests the thread debugging library GDB > is using for the current inferior. > > * "maint set/show check-libthread-db" selects whether libthread_db > tests should be run automatically as libthread_db is auto-loaded. > The default is to not run tests automatically. > > The test itself is a basic integrity check exercising all libthread_db > functions used by GDB on GNU/Linux systems. By extension this also > exercises the proc_service functions provided by GDB that libthread_db > uses. This is useful for NPTL developers and libthread_db developers. > It could also prove useful investigating bugs reported against GDB > where the thread debugging library or GDB's proc_service layer is > suspect. > > GDB changes since version 1: > - The check no longer requires debuginfo for glibc. [Simon] > - Parts of the check are skipped when working with core files. > (I hadn't checked this until Pedro asked about them). > Previously the check would fail because one of the tested > operations does not work with core files on some platforms. > - Macros starting with double underscores have been renamed. [Pedro] > (The macros have been somewhat reorganized too, to implement > the core files change I mentioned above). > - libthread_db_debug now is treated as a boolean in the place > where previously it wasn't. [Simon] > - There is a NEWS entry. [Pedro] > > Testcase changes since version 1: > - Test names no longer contain parentheses. [Simon] > - The criteria for skipping the test have been replaced with > Pedro's suggestion. [Pedro] > - Numbers in testcase comments have been removed. [Pedro] > > Built and regtested on RHEL 7.5 x86_64. > > Ok to commit? > > Thanks, > Gary The patch looks good from my side. Simon