From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by sourceware.org (Postfix) with ESMTPS id 3BDBB3844044 for ; Fri, 10 Jul 2020 20:08:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 3BDBB3844044 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f65.google.com with SMTP id b6so7099016wrs.11 for ; Fri, 10 Jul 2020 13:08:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7gyWco9W0E06sJFbRNDs/zH2jJbCEQJyT53duP+Q90Y=; b=iV4mhr5S0dhb4n/HFkrSE6EdwmEDmxhGJlJn5Q+LAt9ctskUFl4OqSdmPmksEXFz8C t+bOxZut/NVMvadOez82YGELsNY4ncR+CqqffW2A5kbpTaFtoX+w4Nn2FH0HMDXyrmH1 oquupd7ufnZH+zMSl0kkJkSbDhZuSPFGhFr1yWvJwU0ec14WqBqkGrEsdxYzyAOIzFM+ uXtG1EaXI4rdsmKpbGrFcwMtVBK5xL9uEMdZdSDnGHbJKGa3Q3CEnbwhUtwlY56StsC6 aEOmPjQhU1bFyjzzm7BjN2GAksG6ysHpItyAjm3/n9W9kEjs2mNCHXNpAlbKl/noeJGX Nwsg== X-Gm-Message-State: AOAM532SaHk3oT0CAtbZ7oUBkrwoLvNaTTeV1pYeTjl40mWDI8GiA4ih LUGbZSLH8Rs76v/VzlZFzOXvN2EuAJI= X-Google-Smtp-Source: ABdhPJwdNKb3oXQmA3C969YefHHCTQjHYcqim3N59xVrmUQmQWZgVuc7BR1Q8QGTNpeaNF4b0pUD7Q== X-Received: by 2002:adf:d084:: with SMTP id y4mr67811028wrh.161.1594411697166; Fri, 10 Jul 2020 13:08:17 -0700 (PDT) Received: from ?IPv6:2001:8a0:f91a:c400:56ee:75ff:fe8d:232b? ([2001:8a0:f91a:c400:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id x18sm11435818wrq.13.2020.07.10.13.08.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2020 13:08:16 -0700 (PDT) Subject: Re: [PATCH v4 12/14] Add new command "maint print core-file-backed-mappings" To: Kevin Buettner , gdb-patches@sourceware.org References: <20200705225807.2264705-1-kevinb@redhat.com> <20200705225807.2264705-13-kevinb@redhat.com> From: Pedro Alves Message-ID: <24e598f3-2de5-f34c-c4ab-47a1cda89ec9@palves.net> Date: Fri, 10 Jul 2020 21:08:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20200705225807.2264705-13-kevinb@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 10 Jul 2020 20:08:22 -0000 On 7/5/20 11:58 PM, Kevin Buettner via Gdb-patches wrote: > + for (const struct target_section *tsp = m_core_file_mappings.sections; > + tsp < m_core_file_mappings.sections_end; tsp++ ) > + { Spurious space after tsp++. If you need to break the for line, I personally prefer to then put each statement in its own line, like: for (const struct target_section *tsp = m_core_file_mappings.sections; tsp < m_core_file_mappings.sections_end; ++tsp) > +static void > +maintenance_print_core_file_backed_mappings (const char *args, int from_tty) > +{ > + core_target *targ = get_current_core_target (); > + gdb_assert (targ != nullptr); This assert will crash GDB if you're debugging a core dump, right? That doesn't look right. (Please add a test for that.) > + targ->info_proc_mappings (targ->core_gdbarch ()); > +} I don't understand what this command provides that "info proc mappings" doesn't? Can you give an example of when you'd use this command over "info proc mappings" ? Thanks, Pedro Alves