From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 5A2DB3858D28 for ; Fri, 12 Aug 2022 15:44:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5A2DB3858D28 Received: from pps.filterd (m0098420.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 27CEkMHA008038 for ; Fri, 12 Aug 2022 15:44:33 GMT Received: from ppma02dal.us.ibm.com (a.bd.3ea9.ip4.static.sl-reverse.com [169.62.189.10]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3hwrwna4gq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 12 Aug 2022 15:44:32 +0000 Received: from pps.filterd (ppma02dal.us.ibm.com [127.0.0.1]) by ppma02dal.us.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 27CFL61A012859 for ; Fri, 12 Aug 2022 15:44:32 GMT Received: from b03cxnp08028.gho.boulder.ibm.com (b03cxnp08028.gho.boulder.ibm.com [9.17.130.20]) by ppma02dal.us.ibm.com with ESMTP id 3hvkjhe84r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 12 Aug 2022 15:44:31 +0000 Received: from b03ledav003.gho.boulder.ibm.com (b03ledav003.gho.boulder.ibm.com [9.17.130.234]) by b03cxnp08028.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 27CFiUwG65405416 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 12 Aug 2022 15:44:30 GMT Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C8EF66A04D; Fri, 12 Aug 2022 15:44:30 +0000 (GMT) Received: from b03ledav003.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 8D93B6A04F; Fri, 12 Aug 2022 15:44:30 +0000 (GMT) Received: from li-e362e14c-2378-11b2-a85c-87d605f3c641.ibm.com (unknown [9.211.56.41]) by b03ledav003.gho.boulder.ibm.com (Postfix) with ESMTP; Fri, 12 Aug 2022 15:44:30 +0000 (GMT) Message-ID: <2504d72c556db401d3c7e89ea5668c901b57a3f6.camel@us.ibm.com> Subject: Re: [PATCH ver 2] Fix hardware watchpoint check in test gdb.base/watchpoint-reuse-slot.exp From: Carl Love To: Ulrich Weigand , "gdb-patches@sourceware.org" Date: Fri, 12 Aug 2022 08:44:30 -0700 In-Reply-To: References: <3783e7e44fe188af5ca1f2ddcfa4c7f5cb7a818e.camel@us.ibm.com> <47fd087cd94544b980aab5eed9f6113ab5a183f9.camel@us.ibm.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5 (3.28.5-18.el8) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: nFvdo4w_Mg-zzy9SzLEV5OOn_MiyMPAc X-Proofpoint-ORIG-GUID: nFvdo4w_Mg-zzy9SzLEV5OOn_MiyMPAc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-08-12_10,2022-08-11_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 adultscore=0 bulkscore=0 lowpriorityscore=0 phishscore=0 mlxlogscore=858 mlxscore=0 priorityscore=1501 impostorscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2207270000 definitions=main-2208120042 X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 12 Aug 2022 15:44:34 -0000 On Fri, 2022-08-12 at 12:23 +0000, Ulrich Weigand wrote: > Carl Love wrote: > > > However HW watchpoints are disabled on Power 9 due to a HW bug. > > The > > skip_hw_watchpoint_access_tests check needs to be used to properly > > determine if HW watchpoints are supported by the processor. > > This is not quite correct: skip_hw_watchpoint_access_tests checks > whether *access* watchpoints ("awatch") are supported. This is > not really the issue here, since access watchpoints are treated > as optional by this test case already. > > Rather, the problem on Power 9 is that HW watchpoints *in general* > (i.e. all of "watch", "rwatch", and "awatch") are not supported. > To test this, you should use skip_hw_watchpoint_tests, not > skip_hw_watchpoint_access_tests. > > > > +if {[skip_hw_watchpoint_access_tests]} { > > + set supports_hw_wp 0 > > +} else { > > + set supports_hw_wp 1 > > +} > > I guess it would be preferable to use follow break-idempotent.exp > here and simply use: > > set skip_hw_watchpoint_tests_p [skip_hw_watchpoint_tests] > > Otherwise, this looks good to me. OK, thanks for the clarification on the difference between the to checks. I updated the patch to use the same syntax as in the break- idempotent.exp test. I retested on X86, Power 9 and Power 10. I will repost the patch just to make sure it is OK. Note, there are two more tests that use the [target_info exists gdb,no_hardware_watchpoints] and need to be updated. Thanks for the help. Carl