From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 104246 invoked by alias); 18 Apr 2019 17:22:19 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 104237 invoked by uid 89); 18 Apr 2019 17:22:19 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=Didnt, H*M:0556, Didn't X-HELO: mail-wr1-f54.google.com Received: from mail-wr1-f54.google.com (HELO mail-wr1-f54.google.com) (209.85.221.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 17:22:18 +0000 Received: by mail-wr1-f54.google.com with SMTP id t17so3855889wrw.13 for ; Thu, 18 Apr 2019 10:22:18 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id a8sm2861278wmf.33.2019.04.18.10.22.15 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 10:22:15 -0700 (PDT) Subject: Re: Fix compilation using mingw.org's MinGW To: Eli Zaretskii , gdb-patches@sourceware.org References: <835zrbe36c.fsf@gnu.org> From: Pedro Alves Message-ID: <250801eb-14f6-5a35-0556-cf5797dd8a7b@redhat.com> Date: Thu, 18 Apr 2019 17:22:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00353.txt.bz2 On 4/18/19 6:20 PM, Pedro Alves wrote: > On 4/18/19 4:36 PM, Eli Zaretskii wrote: > >> MinGW64 no longer supports versions of Windows older than XP, but >> mingw.org's MinGW does. Since we load GetCurrentConsoleFont >> dynamically at run time, and have code for when the load fails, it >> makes sense to not assume XP at compile time. The patch below does >> that. OK to push (with the pertinent ChangeLog entry)? > > Didn't we drop support for < XP some time ago? > >From gdb/NEWS: ~~~~~~~~~~~~ * Removed targets GDB no longer supports native debugging on versions of MS-Windows before Windows XP. ~~~~~~~~~~~~ So shouldn't we instead be setting _WIN32_WINNT to some appropriate number? Thanks, Pedro Alves