From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 6A075386EC43 for ; Wed, 21 Apr 2021 19:32:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6A075386EC43 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13LJW55J016596 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 21 Apr 2021 15:32:10 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13LJW55J016596 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D46ED1E783; Wed, 21 Apr 2021 15:32:05 -0400 (EDT) Subject: Re: [PATCH 1/6] gdb/infcmd: remove the unused parameter 'args' in 'attach_post_wait' To: Tom Tromey , Tankut Baris Aktemur via Gdb-patches References: <0013ebfdeb103a5142264bf02fc7abc4628a572a.1619009681.git.tankut.baris.aktemur@intel.com> <87czunbfuc.fsf@tromey.com> From: Simon Marchi Message-ID: <251cc136-94ee-5c07-e461-a3ca527cc270@polymtl.ca> Date: Wed, 21 Apr 2021 15:32:05 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87czunbfuc.fsf@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 21 Apr 2021 19:32:05 +0000 X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Apr 2021 19:32:12 -0000 On 2021-04-21 3:24 p.m., Tom Tromey wrote: >>>>>> ">" == Tankut Baris Aktemur via Gdb-patches writes: > >>> gdb/ChangeLog: >>> 2021-04-21 Tankut Baris Aktemur > >>> * infcmd.c (attach_post_wait): Remove the unused parameter 'args'. >>> Update the references below. >>> (struct attach_command_continuation_args) >>> (attach_command_continuation) >>> (attach_command_continuation_free_args) >>> (attach_command) >>> (notice_new_inferior): Update to remove the reference to 'args'. > > Normally it's good to have some text in the body that explains the > commit. I agree with you in general, but when I do patches like this one (remove unused parameter / variable), I also find it hard to find anything else to say than just repeating the subject. Simon