From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7E08C3858D28 for ; Thu, 26 Jan 2023 03:01:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7E08C3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4E6DC1E112; Wed, 25 Jan 2023 22:01:53 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1674702113; bh=2dwEBzT6tJXU+Lb+RPv4VqMhW0ovPOkCJVibxXGhnC8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=VYWWoopL2xD+YUv4fgimJyl3V+38rIrVFsaFwVPcsRZ2yms7XnmVKCTwteRIwfhyO X/KL/pyJvkdwS1vEiVoUKRHPIUWDOldwKtoSMWYX2lX69M8EILzQBwZX3vQeARSpSZ DqlF7ZjGWyfe0c9ICUSmcANbjJYimcnnGFs4/IiU= Message-ID: <2542ebe8-bd2d-a0b1-74ce-faca47530c63@simark.ca> Date: Wed, 25 Jan 2023 22:01:52 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH 3/9] gdb/testsuite/dap: write requests to gdb.log Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi References: <20230106185729.42372-1-simon.marchi@efficios.com> <20230106185729.42372-4-simon.marchi@efficios.com> <87edritgss.fsf@tromey.com> From: Simon Marchi In-Reply-To: <87edritgss.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 1/25/23 17:01, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> This helps following what happens when reading gdb.log. The downside is > Simon> that it becomes harder to tell what text is from GDB and what text is > Simon> going to GDB, but I think that seeing responses without seeing requests > Simon> is even more confusing. At least, the lines are prefix with >>>, so > Simon> when you see this, you know that until the end of the line, it's > Simon> something that was sent to GDB, and not GDB output. > > I meant to mention -- the full DAP I/O is in the test subdir. > E.g. look at gdb/testsuite/outputs/gdb.dap/basic-dap/dap.log.1 in the > build tree. Yeah, I saw that. But to debug the actual test, I found that having the full communication in gdb.log was a bit easier, to correlate with passes and fails. Simon