From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108518 invoked by alias); 13 Dec 2017 14:42:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108503 invoked by uid 89); 13 Dec 2017 14:42:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 13 Dec 2017 14:42:15 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id vBDEg8SP009777 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 13 Dec 2017 09:42:13 -0500 Received: by simark.ca (Postfix, from userid 112) id CDA931E585; Wed, 13 Dec 2017 09:42:08 -0500 (EST) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 787711E4F2; Wed, 13 Dec 2017 09:42:08 -0500 (EST) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 13 Dec 2017 14:42:00 -0000 From: Simon Marchi To: Stafford Horne Cc: GDB patches Subject: Re: [PATCH] gdb: Fix ARI warnings in or1k-tdep.c In-Reply-To: <20171213132654.19739-1-shorne@gmail.com> References: <20171213132654.19739-1-shorne@gmail.com> Message-ID: <2556a7d4118d25c5fbf496de060244b3@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.2 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 13 Dec 2017 14:42:08 +0000 X-IsSubscribed: yes X-SW-Source: 2017-12/txt/msg00307.txt.bz2 On 2017-12-13 08:26, Stafford Horne wrote: > Fix a few issues not using the gettext _() wrapper and issues where > we are using %p directly instead of the dedicated host/target > functions. > > gdb/ChangeLog: > > yyyy-mm-dd Stafford Horne > > * or1k-tdep.c (or1k_analyse_inst): Use _() wrapper for message > strings. > (or1k_unwind_pc): Use paddress() instead of %p. > (or1k_unwind_sp ): Likewise. Spurious space here. Otherwise, LGTM. Simon