Re: [PATCH v4 1/4] gdb, infrun, btrace: fix reverse/replay stepping at end of execution history

[Hannes Domani <ssbssa@yahoo.de>]

 Am Dienstag, 12. März 2024 um 12:35:10 MEZ hat Markus Metzger <markus.t.metzger@intel.com> Folgendes geschrieben:

> When trying to step over a breakpoint at the end of the trace, the
> step-over will fail with no-history.  This does not clear step_over_info
> so a subsequent resume will cause GDB to not resume the thread and expect
> a SIGTRAP to complete the step-over.  This will never come causing GDB to
> hang in the wait-for-event poll.
>
> That step-over failed after actually completing the step.  This is wrong.
> The step-over itself should have failed and the step should not have
> completed.  Fix it by moving the end of execution history check to before
> we are stepping.
>
> This exposes another issue, however.  When completing a step-over at the
> end of the execution history, we implicitly stop replaying that thread.  A
> continue command would resume after the step-over and, since we're no
> longer replaying, would continue recording.
>
> Fix that by recording the replay state in the thread's control state and
> failing with no-history in keep_going if we're switching from replay to
> recording.

That sounds a lot like https://sourceware.org/bugzilla/show_bug.cgi?id=31353.


Hannes