From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [RFA 0/9] Enable -Wimplicit-fallthrough
Date: Fri, 04 May 2018 17:51:00 -0000 [thread overview]
Message-ID: <257be5cb-74f7-6f4e-48a7-bea36fbab9c3@redhat.com> (raw)
In-Reply-To: <20180421183056.29292-1-tom@tromey.com>
On 04/21/2018 07:30 PM, Tom Tromey wrote:
> This series enables -Wimplicit-fallthrough for gdb. I think this is
> valuable because it can prevent the occasional bug.
Agreed.
>
> A couple of the patches are straightforward. For example, patch #1
> changes existing "fall-through" comments to the correct form that will
> be recognized by GCC.
>
> In some cases I was not sure which change to make. I've split all
> these out in this series for easier review. Please examine them
> carefully. This applies to patches 4, 5, 6, and 8.
>
> I chose to use comments rather than the new fall-through attribute
> because the comments are more portable: they can be ignored by
> compilers that do not understand them, and they do not require
> additional configury.
Yeah. Maybe we'll be able to use [[fallthough]] at some point.
I sent a comment to patch 9/9.
Please update the commit log of patch 5/9 reflecting John's
finding, if it makes sense.
Otherwise looks good to me. Please push. You'll need to
regenerate the configure scripts.
Thanks,
Pedro Alves
prev parent reply other threads:[~2018-05-04 17:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-21 18:31 Tom Tromey
2018-04-21 18:31 ` [RFA 9/9] Add -Wimplicit-fallthrough Tom Tromey
2018-05-04 18:34 ` Pedro Alves
2018-05-04 18:47 ` Tom Tromey
2018-04-21 18:31 ` [RFA 2/9] Add missing ATTRIBUTE_NORETURNs Tom Tromey
2018-04-21 18:31 ` [RFA 6/9] Add two fall-through comments in rs6000-tdep.c Tom Tromey
2018-04-21 18:31 ` [RFA 8/9] Add a missing break in record_linux_system_call Tom Tromey
2018-04-21 18:31 ` [RFA 4/9] Add a fall-through comment to stabsread.c Tom Tromey
2018-04-21 18:31 ` [RFA 3/9] Fix "obvious" fall-through warnings Tom Tromey
2018-04-21 18:31 ` [RFA 5/9] Add fall-through comment to i386-tdep.c Tom Tromey
2018-04-24 20:37 ` John Baldwin
2018-04-21 18:31 ` [RFA 1/9] Fix "fall through" comments Tom Tromey
2018-04-21 18:31 ` [RFA 7/9] Add missing "breaks" Tom Tromey
2018-05-04 17:51 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=257be5cb-74f7-6f4e-48a7-bea36fbab9c3@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).