Re: [PATCHv2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant

[Hannes Domani <ssbssa@yahoo.de>]

 Am Samstag, 5. Juni 2021, 14:27:18 MESZ hat Tom de Vries <tdevries@suse.de> Folgendes geschrieben:

> On 6/3/21 3:00 PM, Hannes Domani via Gdb-patches wrote:
> >  Am Mittwoch, 2. Juni 2021, 20:39:58 MESZ hat Tom Tromey <tom@tromey.com> Folgendes geschrieben:
> >
> >>>>>>> "Hannes" == Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> writes:
> >>
> >> Hannes> It was removed (probably by mistake) in
> >> Hannes> 51e78fc5fa21870d415c52f90b93e3c6ad57be46.
> >>
> >> Yes, sorry about that.
> >>
> >> Hannes> gdb/ChangeLog:
> >>
> >> Hannes> 2021-05-26  Hannes Domani  <ssbssa@yahoo.de>
> >>
> >> Hannes>     * python/py-symbol.c (gdbpy_initialize_symbols): Restore
> >> Hannes>     gdb.SYMBOL_LABEL_DOMAIN constant.
> >>
> >> Hannes> gdb/testsuite/ChangeLog:
> >>
> >> Hannes> 2021-05-26  Hannes Domani  <ssbssa@yahoo.de>
> >>
> >> Hannes>     * gdb.python/py-symbol.exp: Test symbol constants.
> >>
> >> This is ok.  Thank you.
> >>
> >> Hannes> +# Test gdb.Symbol domain categories
> >> Hannes> +gdb_test "python print gdb.SYMBOL_UNDEF_DOMAIN" \
> >> Hannes> +    "0" "test gdb.SYMBOL_UNDEF_DOMAIN"
> >> Hannes> +gdb_test "python print gdb.SYMBOL_VAR_DOMAIN" \
> >> Hannes> +    "1" "test gdb.SYMBOL_VAR_DOMAIN"
> >>
> >> While we don't want people to rely on the values of these constants, it
> >> seems harmless in the test suite.  If someone changes one, they can just
> >> update the test.
> >
> > Pushed, thanks.
>
> With python 3, I'm running into:
> ...
> (gdb) PASS: gdb.python/py-symbol.exp: test symbol destructor
> python print gdb.SYMBOL_UNDEF_DOMAIN^M
>   File "<string>", line 1^M
>     print gdb.SYMBOL_UNDEF_DOMAIN^M
>             ^^M
> SyntaxError: Missing parentheses in call to 'print'. Did you mean
> print(gdb.SYMBOL_UNDEF_DOMAIN)?^M
> Error while executing Python code.^M
> (gdb) FAIL: gdb.python/py-symbol.exp: test gdb.SYMBOL_UNDEF_DOMAIN
> ...

Sorry about that.
I'm gonna push the below as obvious.


Hannes


From fb3f973143033b3c9c98ee5c34467c81081e71c4 Mon Sep 17 00:00:00 2001
From: Hannes Domani <ssbssa@yahoo.de>
Date: Sat, 5 Jun 2021 14:37:53 +0200
Subject: [PATCH] Fix symbol constants tests for Python 3

gdb/testsuite/ChangeLog:

2021-06-05  Hannes Domani  <ssbssa@yahoo.de>

    * gdb.python/py-symbol.exp: Fix tests for Python 3.
---
 gdb/testsuite/gdb.python/py-symbol.exp | 44 +++++++++++++++++-----------------
 1 file changed, 22 insertions(+), 22 deletions(-)

diff --git a/gdb/testsuite/gdb.python/py-symbol.exp b/gdb/testsuite/gdb.python/py-symbol.exp
index 41b583cd79f..98acdbe3621 100644
--- a/gdb/testsuite/gdb.python/py-symbol.exp
+++ b/gdb/testsuite/gdb.python/py-symbol.exp
@@ -257,49 +257,49 @@ gdb_test "python print (a\[0\].is_valid())" "False" "test symbol non-validity"
 gdb_test_no_output "python a = None" "test symbol destructor"
 
 # Test gdb.Symbol domain categories
-gdb_test "python print gdb.SYMBOL_UNDEF_DOMAIN" \
+gdb_test "python print (gdb.SYMBOL_UNDEF_DOMAIN)" \
     "0" "test gdb.SYMBOL_UNDEF_DOMAIN"
-gdb_test "python print gdb.SYMBOL_VAR_DOMAIN" \
+gdb_test "python print (gdb.SYMBOL_VAR_DOMAIN)" \
     "1" "test gdb.SYMBOL_VAR_DOMAIN"
-gdb_test "python print gdb.SYMBOL_STRUCT_DOMAIN" \
+gdb_test "python print (gdb.SYMBOL_STRUCT_DOMAIN)" \
     "2" "test gdb.SYMBOL_STRUCT_DOMAIN"
-gdb_test "python print gdb.SYMBOL_MODULE_DOMAIN" \
+gdb_test "python print (gdb.SYMBOL_MODULE_DOMAIN)" \
     "3" "test gdb.SYMBOL_MODULE_DOMAIN"
-gdb_test "python print gdb.SYMBOL_LABEL_DOMAIN" \
+gdb_test "python print (gdb.SYMBOL_LABEL_DOMAIN)" \
     "4" "test gdb.SYMBOL_LABEL_DOMAIN"
-gdb_test "python print gdb.SYMBOL_COMMON_BLOCK_DOMAIN" \
+gdb_test "python print (gdb.SYMBOL_COMMON_BLOCK_DOMAIN)" \
     "5" "test gdb.SYMBOL_COMMON_BLOCK_DOMAIN"
 
 # Test gdb.Symbol address class categories
-gdb_test "python print gdb.SYMBOL_LOC_UNDEF" \
+gdb_test "python print (gdb.SYMBOL_LOC_UNDEF)" \
     "0" "test gdb.SYMBOL_LOC_UNDEF"
-gdb_test "python print gdb.SYMBOL_LOC_CONST" \
+gdb_test "python print (gdb.SYMBOL_LOC_CONST)" \
     "1" "test gdb.SYMBOL_LOC_CONST"
-gdb_test "python print gdb.SYMBOL_LOC_STATIC" \
+gdb_test "python print (gdb.SYMBOL_LOC_STATIC)" \
     "2" "test gdb.SYMBOL_LOC_STATIC"
-gdb_test "python print gdb.SYMBOL_LOC_REGISTER" \
+gdb_test "python print (gdb.SYMBOL_LOC_REGISTER)" \
     "3" "test gdb.SYMBOL_LOC_REGISTER"
-gdb_test "python print gdb.SYMBOL_LOC_ARG" \
+gdb_test "python print (gdb.SYMBOL_LOC_ARG)" \
     "4" "test gdb.SYMBOL_LOC_ARG"
-gdb_test "python print gdb.SYMBOL_LOC_REF_ARG" \
+gdb_test "python print (gdb.SYMBOL_LOC_REF_ARG)" \
     "5" "test gdb.SYMBOL_LOC_REF_ARG"
-gdb_test "python print gdb.SYMBOL_LOC_REGPARM_ADDR" \
+gdb_test "python print (gdb.SYMBOL_LOC_REGPARM_ADDR)" \
     "6" "test gdb.SYMBOL_LOC_REGPARM_ADDR"
-gdb_test "python print gdb.SYMBOL_LOC_LOCAL" \
+gdb_test "python print (gdb.SYMBOL_LOC_LOCAL)" \
     "7" "test gdb.SYMBOL_LOC_LOCAL"
-gdb_test "python print gdb.SYMBOL_LOC_TYPEDEF" \
+gdb_test "python print (gdb.SYMBOL_LOC_TYPEDEF)" \
     "8" "test gdb.SYMBOL_LOC_TYPEDEF"
-gdb_test "python print gdb.SYMBOL_LOC_LABEL" \
+gdb_test "python print (gdb.SYMBOL_LOC_LABEL)" \
     "9" "test gdb.SYMBOL_LOC_LABEL"
-gdb_test "python print gdb.SYMBOL_LOC_BLOCK" \
+gdb_test "python print (gdb.SYMBOL_LOC_BLOCK)" \
     "10" "test gdb.SYMBOL_LOC_BLOCK"
-gdb_test "python print gdb.SYMBOL_LOC_CONST_BYTES" \
+gdb_test "python print (gdb.SYMBOL_LOC_CONST_BYTES)" \
     "11" "test gdb.SYMBOL_LOC_CONST_BYTES"
-gdb_test "python print gdb.SYMBOL_LOC_UNRESOLVED" \
+gdb_test "python print (gdb.SYMBOL_LOC_UNRESOLVED)" \
     "12" "test gdb.SYMBOL_LOC_UNRESOLVED"
-gdb_test "python print gdb.SYMBOL_LOC_OPTIMIZED_OUT" \
+gdb_test "python print (gdb.SYMBOL_LOC_OPTIMIZED_OUT)" \
     "13" "test gdb.SYMBOL_LOC_OPTIMIZED_OUT"
-gdb_test "python print gdb.SYMBOL_LOC_COMPUTED" \
+gdb_test "python print (gdb.SYMBOL_LOC_COMPUTED)" \
     "14" "test gdb.SYMBOL_LOC_COMPUTED"
-gdb_test "python print gdb.SYMBOL_LOC_COMMON_BLOCK" \
+gdb_test "python print (gdb.SYMBOL_LOC_COMMON_BLOCK)" \
     "15" "test gdb.SYMBOL_LOC_COMMON_BLOCK"
--
2.15.1.windows.2