From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from sonic314-19.consmr.mail.ir2.yahoo.com (sonic314-19.consmr.mail.ir2.yahoo.com [77.238.177.145]) by sourceware.org (Postfix) with ESMTPS id B9B0F385042B for ; Sat, 5 Jun 2021 12:43:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B9B0F385042B X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1622896991; bh=sqKzMQ+sRoifP0Z0tLkOFVOUZHVIpENDRj6b1ggVyVa=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=ADuSonlsrx6DvBg8Qn54U2jRy9HjMsMiK1MUWN+0u7uO2yHzxlNdu7jIk6rExcn6+d3Zp4sqOIAOVMAcV2XRAGX50YGiGh5rca+uvVz5unveNfzMeyrHeAaxT5Kd23bPRiIBx9ljnSM2jeQasnnm79qEpkKNvZaKZbN0eeOOKXwUFVr7nNYheypJRw7Cr/OWussj7ZPyMUGhmYzTpqIMMF7PYpv7uiyFpTHxa3fbiEcj/W8s6giGPLWIxantu/ytm2nkwrEt68mdy0IYIT2t7QGmAC8ciixa6w2GdB3hnHGQqqi5YCFIRqCkFmbkEtpFZcCgrx364efhy17ufQAjdw== X-YMail-OSG: 22Hsoh8VM1l5LRPYcTFYl2XZir_Scg8YwHkimVdg3uOfnfKzm7t9P5N90AXnUK0 W39lv7_d_mBrlAI9jANlO772T1P7QMuZ.RJmPPMSjfKArR1J52w5N0WhSRe22adPGBmK2acgsQRF qnGB5fsB7aZldb59TJObcAqc_2Gn7SFGV0u6WSicfQ.yLDxXhC0IFL_RCQw5LVdIDMa2emN5rC9Z 15K3A_PL6yIozEXXL8TCoki5rebfltt3TAGlQqMrSw8Bm0TKu6RNd9oHbcTwi8k6PoaRet7dIcZl wR4VIC7Y.RfIQl1stetVJ_TAKnXIpu6PvvWsb6ZlZrXbzLhuR7SX2QUCZrAobRGtgSADoqKWWavZ ChjFxWLKWuqvaBOyIbfN5V133bzggYkYEuxH9iTZlrhR4oyarHM_z0WsfCjMVMZO2R2jxVrDMO32 thC72cgUDHXZRplYHPAMJ_A7gElK_m6HPj_Yc1foyFYa676j6ih_dFPIlnA3RT5mqeIWv9Ivkncd bjKI1lQ.0zNgesNbt1tZuXmfEaXyIkj125dRfrt9b.G3Sed9HK5S93R6CWHTCbwLp0NoKNKHlaPY .foKPd4YYjWI5uzeHJ9TgnbaW0dt19m2RJUNH3L0kxdQCWz7ifKgDsB3ow3tw0dOvbcS1TaQ3RK5 5T852xgJz2IFk9FfZ3UDW7xA5V6UVPqwz_i2gNmtqCtorIMgzXaz_nH2kmVSjZjHAXRHEufSy.U9 tnSwqgOpCBQwB70mWG.pjMOgW4eFMHWis40o_MOMW4pSkeIeCD9OUv2EtOLfG5bemCytGeH9iQNb qr_b3W8CO1PohScny3Trg042wzzAzYX_HsCmriM5SKjCzfXiABYGqfSrdJoTdj_iLKb9eY_BK4FD pGvaQ2vE_wMPlIOxThRwF.u7ZqmuU0kn8rBiZKM2yVXRLAEPIbxT7UAStDnes4MVPpvfMYfPeCEx jZP1XzY4TsrKS_m8xOpsubOuHMZQAyuQUTFgrpxMdCN3jNY2PqCkzx5CBER7SXbh02cuv9H7tj1Z xMVVeQe0v47zhuYrmV2GzYZfvXf3iM1l4mrNv6imvI8m5NdmePoMzfMjUSq0qiL8zL5mteFA3BXE 9OZbL1j38mytjaLzoNF8cQPniWN4ZVuImO9eFJsJ1hI3AgDduQVmGK67kdgT0UZKQRDj_ifu6ITr FGJRH11fH9j8Ezum0_0JoNa6g5wOc6yKysW_0.5G4pJY93GvjMYYGF3QYp7iydYuN5j7zwldS0yC Id0U5LVdyZJYkGbop9Ejkr8Mfl8za7cNoLII8WJuAB7sX7TAJytLYJ8zOS7rr1Txgvzaby3LqYTt uPgcid52YRggYZbLWk.7Z2TPCVfaNseQNQzdJ63PwDJuFOaddlo1JRAByz4Z.S0t_CjCHJaCMeZN pWPwtiIRBBzz2faqPygVmHpLP3vMl_0XqdNFlJXurYV45wFZVjCZPPLwW5LYjSZr23DrDIXtZphz U.mY_Uej3rjBoWU3DDm2MerSm3EG.N99ILormYri4ncbjV8h1CJZ_rwbjDrNbMTcJVR5KKu2fSMJ 9xZMVvI_3yZ49NNrs8A9DvM4FlMAf5PpMXuQVueX0c8lj2WBNMXmV5JIE24lWvd1_djpjANzJzwW VYJ2bgbLII38.j_WnQtqPF.1v_3eamuE6VYzZ_HifkuXsPuNfQJWMEqaOXm2KvhsfQuLcvSkcqro LeNE2roAG0F42GT44ILxhQ4D2baFhPi3o6AnADjJSaCrbVr90P9TzdmEs5vVM3ua7c3pFGPXXHCA 16C7EP9xJ3wIhXjC17PlPVU6vWW18Op5EtzmvkGU6A3xT1HIId29m3UNWihvJ7lQ9d2npD0QziA1 uH4HTPn6Y2BsDgv67RhPq1Cp8DcFlHgwQcGNA8IyviwQTjAsPGuz8zT9gW8Ml2fOzlGqGm7lA7.z 9s1W_H4xJn6gKhWNjCTzBP0EvEa2cZyFe7LWFZz9P5QnpM6If0G1XaylNY5whHS4QML53ypDlNJs 84NJ_LA29G7TXzHXNMHaeQk1WyG6yHZxuDulFGvjT9Z50FNd7iCAjMOCKanwyZuH6tBXZkC3izdn HclBrH_u50EpWvURhYTwE7MnDt9sxTke4LlPYCA8ZWMDshSRgsnu_Zh1rb_h63H7Zuud3Hr7pMi7 WR8X300BDM_hqP48vsH_zWbzj9pbr2CeHXYk5n6ThDbqsFhgPkB9KcZ_s8FLP8i4GzbQ7549yQDl zOLheUGhV7G50YxsaFcRkidL7.WLOHxOLdFz0tDHSP7FYpx0HVLaZJxTu.T9E0HVDw9TxA98Es4o 1pN5YYJ6XugPKsb31CQ.bCoRNs5Dkht.MN5.OWj9hS816oXlVZr7csdm27eYhnt5gaWeYTnzHX.T YNwoOvCjlrzn1Vo_OF9pu9Xv8NZBHC6_qhO5KeNuHPUIIvcdMsWKjc8J0G.uqqAp5yLYNjn.PceK nh8x2FwdQ2nFZO7YsLtcj5mIS8Q5TA7RJHurecfa2ICVcHCwfZ1WfVyl.jmA6dnci0HVr_8xHZA3 rZs4t X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic314.consmr.mail.ir2.yahoo.com with HTTP; Sat, 5 Jun 2021 12:43:11 +0000 Date: Sat, 5 Jun 2021 12:43:07 +0000 (UTC) From: Hannes Domani To: Hannes Domani via Gdb-patches , Tom Tromey , Tom de Vries Message-ID: <259660019.5490657.1622896987146@mail.yahoo.com> In-Reply-To: <6f5127bc-9967-4b17-b851-2f14276e3b5e@suse.de> References: <20210526170536.657-1-ssbssa.ref@yahoo.de> <20210526170536.657-1-ssbssa@yahoo.de> <87k0ncp0v4.fsf@tromey.com> <2129329660.4623528.1622725230456@mail.yahoo.com> <6f5127bc-9967-4b17-b851-2f14276e3b5e@suse.de> Subject: Re: [PATCHv2] Restore gdb.SYMBOL_STRUCT_DOMAIN constant MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Mailer: WebService/1.1.18368 YMailNorrin X-Spam-Status: No, score=-7.9 required=5.0 tests=BAYES_00, BODY_8BITS, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, KAM_STOCKGEN, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 05 Jun 2021 12:43:23 -0000 Am Samstag, 5. Juni 2021, 14:27:18 MESZ hat Tom de Vries Folgendes geschrieben: > On 6/3/21 3:00 PM, Hannes Domani via Gdb-patches wrote: > >=C2=A0 Am Mittwoch, 2. Juni 2021, 20:39:58 MESZ hat Tom Tromey Folgendes geschrieben: > > > >>>>>>> "Hannes" =3D=3D Hannes Domani via Gdb-patches writes: > >> > >> Hannes> It was removed (probably by mistake) in > >> Hannes> 51e78fc5fa21870d415c52f90b93e3c6ad57be46. > >> > >> Yes, sorry about that. > >> > >> Hannes> gdb/ChangeLog: > >> > >> Hannes> 2021-05-26=C2=A0 Hannes Domani=C2=A0 > >> > >> Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 * python/py-symbol.c (gdbpy_initialize= _symbols): Restore > >> Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 gdb.SYMBOL_LABEL_DOMAIN constant. > >> > >> Hannes> gdb/testsuite/ChangeLog: > >> > >> Hannes> 2021-05-26=C2=A0 Hannes Domani=C2=A0 > >> > >> Hannes>=C2=A0=C2=A0=C2=A0=C2=A0 * gdb.python/py-symbol.exp: Test symbo= l constants. > >> > >> This is ok.=C2=A0 Thank you. > >> > >> Hannes> +# Test gdb.Symbol domain categories > >> Hannes> +gdb_test "python print gdb.SYMBOL_UNDEF_DOMAIN" \ > >> Hannes> +=C2=A0=C2=A0=C2=A0 "0" "test gdb.SYMBOL_UNDEF_DOMAIN" > >> Hannes> +gdb_test "python print gdb.SYMBOL_VAR_DOMAIN" \ > >> Hannes> +=C2=A0=C2=A0=C2=A0 "1" "test gdb.SYMBOL_VAR_DOMAIN" > >> > >> While we don't want people to rely on the values of these constants, i= t > >> seems harmless in the test suite.=C2=A0 If someone changes one, they c= an just > >> update the test. > > > > Pushed, thanks. > > With python 3, I'm running into: > ... > (gdb) PASS: gdb.python/py-symbol.exp: test symbol destructor > python print gdb.SYMBOL_UNDEF_DOMAIN^M >=C2=A0=C2=A0 File "", line 1^M >=C2=A0=C2=A0=C2=A0=C2=A0 print gdb.SYMBOL_UNDEF_DOMAIN^M >=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 ^= ^M > SyntaxError: Missing parentheses in call to 'print'. Did you mean > print(gdb.SYMBOL_UNDEF_DOMAIN)?^M > Error while executing Python code.^M > (gdb) FAIL: gdb.python/py-symbol.exp: test gdb.SYMBOL_UNDEF_DOMAIN > ... Sorry about that. I'm gonna push the below as obvious. Hannes >From fb3f973143033b3c9c98ee5c34467c81081e71c4 Mon Sep 17 00:00:00 2001 From: Hannes Domani Date: Sat, 5 Jun 2021 14:37:53 +0200 Subject: [PATCH] Fix symbol constants tests for Python 3 gdb/testsuite/ChangeLog: 2021-06-05=C2=A0 Hannes Domani=C2=A0 =C2=A0=C2=A0 =C2=A0* gdb.python/py-symbol.exp: Fix tests for Python 3. --- =C2=A0gdb/testsuite/gdb.python/py-symbol.exp | 44 +++++++++++++++++--------= --------- =C2=A01 file changed, 22 insertions(+), 22 deletions(-) diff --git a/gdb/testsuite/gdb.python/py-symbol.exp b/gdb/testsuite/gdb.pyt= hon/py-symbol.exp index 41b583cd79f..98acdbe3621 100644 --- a/gdb/testsuite/gdb.python/py-symbol.exp +++ b/gdb/testsuite/gdb.python/py-symbol.exp @@ -257,49 +257,49 @@ gdb_test "python print (a\[0\].is_valid())" "False" "= test symbol non-validity" =C2=A0gdb_test_no_output "python a =3D None" "test symbol destructor" =C2=A0 =C2=A0# Test gdb.Symbol domain categories -gdb_test "python print gdb.SYMBOL_UNDEF_DOMAIN" \ +gdb_test "python print (gdb.SYMBOL_UNDEF_DOMAIN)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "0" "test gdb.SYMBOL_UNDEF_DOMAIN" -gdb_test "python print gdb.SYMBOL_VAR_DOMAIN" \ +gdb_test "python print (gdb.SYMBOL_VAR_DOMAIN)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "1" "test gdb.SYMBOL_VAR_DOMAIN" -gdb_test "python print gdb.SYMBOL_STRUCT_DOMAIN" \ +gdb_test "python print (gdb.SYMBOL_STRUCT_DOMAIN)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "2" "test gdb.SYMBOL_STRUCT_DOMAIN" -gdb_test "python print gdb.SYMBOL_MODULE_DOMAIN" \ +gdb_test "python print (gdb.SYMBOL_MODULE_DOMAIN)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "3" "test gdb.SYMBOL_MODULE_DOMAIN" -gdb_test "python print gdb.SYMBOL_LABEL_DOMAIN" \ +gdb_test "python print (gdb.SYMBOL_LABEL_DOMAIN)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "4" "test gdb.SYMBOL_LABEL_DOMAIN" -gdb_test "python print gdb.SYMBOL_COMMON_BLOCK_DOMAIN" \ +gdb_test "python print (gdb.SYMBOL_COMMON_BLOCK_DOMAIN)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "5" "test gdb.SYMBOL_COMMON_BLOCK_DOMAIN" =C2=A0 =C2=A0# Test gdb.Symbol address class categories -gdb_test "python print gdb.SYMBOL_LOC_UNDEF" \ +gdb_test "python print (gdb.SYMBOL_LOC_UNDEF)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "0" "test gdb.SYMBOL_LOC_UNDEF" -gdb_test "python print gdb.SYMBOL_LOC_CONST" \ +gdb_test "python print (gdb.SYMBOL_LOC_CONST)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "1" "test gdb.SYMBOL_LOC_CONST" -gdb_test "python print gdb.SYMBOL_LOC_STATIC" \ +gdb_test "python print (gdb.SYMBOL_LOC_STATIC)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "2" "test gdb.SYMBOL_LOC_STATIC" -gdb_test "python print gdb.SYMBOL_LOC_REGISTER" \ +gdb_test "python print (gdb.SYMBOL_LOC_REGISTER)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "3" "test gdb.SYMBOL_LOC_REGISTER" -gdb_test "python print gdb.SYMBOL_LOC_ARG" \ +gdb_test "python print (gdb.SYMBOL_LOC_ARG)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "4" "test gdb.SYMBOL_LOC_ARG" -gdb_test "python print gdb.SYMBOL_LOC_REF_ARG" \ +gdb_test "python print (gdb.SYMBOL_LOC_REF_ARG)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "5" "test gdb.SYMBOL_LOC_REF_ARG" -gdb_test "python print gdb.SYMBOL_LOC_REGPARM_ADDR" \ +gdb_test "python print (gdb.SYMBOL_LOC_REGPARM_ADDR)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "6" "test gdb.SYMBOL_LOC_REGPARM_ADDR" -gdb_test "python print gdb.SYMBOL_LOC_LOCAL" \ +gdb_test "python print (gdb.SYMBOL_LOC_LOCAL)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "7" "test gdb.SYMBOL_LOC_LOCAL" -gdb_test "python print gdb.SYMBOL_LOC_TYPEDEF" \ +gdb_test "python print (gdb.SYMBOL_LOC_TYPEDEF)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "8" "test gdb.SYMBOL_LOC_TYPEDEF" -gdb_test "python print gdb.SYMBOL_LOC_LABEL" \ +gdb_test "python print (gdb.SYMBOL_LOC_LABEL)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "9" "test gdb.SYMBOL_LOC_LABEL" -gdb_test "python print gdb.SYMBOL_LOC_BLOCK" \ +gdb_test "python print (gdb.SYMBOL_LOC_BLOCK)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "10" "test gdb.SYMBOL_LOC_BLOCK" -gdb_test "python print gdb.SYMBOL_LOC_CONST_BYTES" \ +gdb_test "python print (gdb.SYMBOL_LOC_CONST_BYTES)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "11" "test gdb.SYMBOL_LOC_CONST_BYTES" -gdb_test "python print gdb.SYMBOL_LOC_UNRESOLVED" \ +gdb_test "python print (gdb.SYMBOL_LOC_UNRESOLVED)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "12" "test gdb.SYMBOL_LOC_UNRESOLVED" -gdb_test "python print gdb.SYMBOL_LOC_OPTIMIZED_OUT" \ +gdb_test "python print (gdb.SYMBOL_LOC_OPTIMIZED_OUT)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "13" "test gdb.SYMBOL_LOC_OPTIMIZED_OUT" -gdb_test "python print gdb.SYMBOL_LOC_COMPUTED" \ +gdb_test "python print (gdb.SYMBOL_LOC_COMPUTED)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "14" "test gdb.SYMBOL_LOC_COMPUTED" -gdb_test "python print gdb.SYMBOL_LOC_COMMON_BLOCK" \ +gdb_test "python print (gdb.SYMBOL_LOC_COMMON_BLOCK)" \ =C2=A0=C2=A0=C2=A0=C2=A0 "15" "test gdb.SYMBOL_LOC_COMMON_BLOCK" -- 2.15.1.windows.2