From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id BD2E5388A827 for ; Mon, 25 May 2020 13:29:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org BD2E5388A827 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 04PDTcU1021943 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 May 2020 09:29:43 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 04PDTcU1021943 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 138191E792; Mon, 25 May 2020 09:29:38 -0400 (EDT) Subject: Re: [PATCH 1/2] gdb/testsuite: add simavr.exp board To: Pedro Alves , gdb-patches@sourceware.org References: <20200524142040.209234-1-simon.marchi@polymtl.ca> <372695e3-7298-5c84-c009-6e41ca953d9f@redhat.com> From: Simon Marchi Message-ID: <25976d2f-2071-49cc-c503-7408e254d06b@polymtl.ca> Date: Mon, 25 May 2020 09:29:37 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: <372695e3-7298-5c84-c009-6e41ca953d9f@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 25 May 2020 13:29:38 +0000 X-Spam-Status: No, score=-9.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 May 2020 13:29:57 -0000 On 2020-05-24 12:33 p.m., Pedro Alves wrote: > On 5/24/20 3:20 PM, Simon Marchi via Gdb-patches wrote: >> After sending "target remote :1234" to GDB, I tried using gdb_expect to >> wait for the "Remote debugging using :1234" message and the GDB prompt. >> That didn't work well, but gdb_test_multiple does work. For example, >> with test gdb.base/break.exp, it blocks at some point when using >> >> gdb_expect { >> -re "Remote debugging using :1234.*$gdb_prompt " {} >> } >> >> If anybody knows how to make gdb_expect work here, I could use it >> (although gdb_test_multiple works fine, except it will probably generate >> a FAIL in cause of failure). > > Strange. gdb_test_multiple is just a wrapper around gdb_expect, so it > should work. Maybe it's sporadic, and gdb_test_multiple only seems > to work better? I'd look at RUNTESTFLAGS="-v -v -v --debug" output > to figure out why the pattern didn't match, causing the hang. Ah, the issue wasn't really gdb_expect or the regex. It's just that gdb_run_cmd expects gdb_reload to return 0 in order to proceed: 268 if { [gdb_reload] != 0 } { 269 return 270 } And tcl has this common shell behavior where a procedure returns the same thing as the last thing it called, without an explicit "return": $ cat test.tcl proc p1 {} { return 17 } proc p2 {} { p1 } puts [p2] $ tclsh test.tcl 17 And gdb_test_multiple just happened to return 0, but gdb_expect did not. Using gdb_expect and adding a `return 0` in my proc made it work. Here's the patch with that fixed: >From 742643b78c9307f9a1e3d6103efb4834295099db Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Sun, 24 May 2020 10:20:39 -0400 Subject: [PATCH] gdb/testsuite: add simavr.exp board This patch adds a board file for against a simavr target (so, for the AVR architecture). simavr, when started with option -g, runs a GDB stub on port 1234. In the current latest release (1.6), the port is hardcoded to 1234. But in master, there is the option to choose another port. So while the board file hardcodes the port today, in the future it should be possible to let the user choose a port, or automatically select a free port. It is easy enough to run, make sure you have avr-gcc/avr-g++ and simavr installed, and as usual just run: make check RUNTESTFLAGS="--target_board=simavr" The following environment variables influence the behavior of the board file: - SIMAVR_MCU: type of chip to simulate - SIMAVR_PATH: path to simavr binary (useful if you build your own simavr or for some reason it is not simply called `simavr`. As expected, there are a lot of failures. Many tests use some features not supported by such a target, and I suppose there are real GDB bugs too. But a lot also passes (including tests that actually run stuff), so this board file should still help to validate changes to the AVR architecture support. These are the results I got of running tests gdb.base/*.exp: # of expected passes 20926 # of unexpected failures 2257 # of expected failures 14 # of unknown successes 1 # of known failures 13 # of unresolved testcases 592 # of untested testcases 156 # of unsupported tests 30 # of paths in test names 3 # of duplicate test names 56 gdb/testsuite/ChangeLog: * boards/simavr.exp: New file. Change-Id: Ib7fa8c4e2e90b08b104bb9b552df37779de3bc21 --- gdb/testsuite/boards/simavr.exp | 94 +++++++++++++++++++++++++++++++++ 1 file changed, 94 insertions(+) create mode 100644 gdb/testsuite/boards/simavr.exp diff --git a/gdb/testsuite/boards/simavr.exp b/gdb/testsuite/boards/simavr.exp new file mode 100644 index 000000000000..660af7ba83f8 --- /dev/null +++ b/gdb/testsuite/boards/simavr.exp @@ -0,0 +1,94 @@ +# Copyright 2020 Free Software Foundation, Inc. + +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +# Let the user override the path to the simavr binary with the SIMAVR_PATH +# environment variable. + +if { [info exists ::env(SIMAVR_PATH)] } { + set simavr_path $::env(SIMAVR_PATH) +} else { + set simavr_path simavr +} + +# Let the user override the simulated AVR chip with the SIMAVR_PATH environment +# variable. +# +# The value passed here must be supported by avr-gcc (see the -mmcu flag in the +# `AVR Options` section of the gcc(1) man page) and by simavr (see output of +# `simavr --list-cores`). + +if { [info exists ::env(SIMAVR_MCU)] } { + set simavr_mcu $::env(SIMAVR_MCU) +} else { + set simavr_mcu atmega2560 +} + +set simavr_last_load_file "" +set simavr_spawn_id "" + +set_board_info compiler avr-gcc +set_board_info c++compiler avr-g++ + +set_board_info cflags "-mmcu=${simavr_mcu}" +set_board_info ldflags "-mmcu=${simavr_mcu}" + +set_board_info use_gdb_stub 1 +set_board_info gdb_protocol "remote" +set_board_info gdb,do_reload_on_run 1 +set_board_info noargs 1 +set_board_info gdb,noinferiorio 1 +set_board_info gdb,nofileio 1 +set_board_info gdb,noresults 1 +set_board_info gdb,nosignals 1 + +proc gdb_load { file } { + global simavr_last_load_file + global simavr_spawn_id + global simavr_mcu + global simavr_path + global gdb_prompt + + if { $file == "" } { + set file $simavr_last_load_file + } else { + set simavr_last_load_file $file + } + + gdb_file_cmd $file + + # Close any previous simavr instance. + if { $simavr_spawn_id != "" } { + close -i $simavr_spawn_id + set simavr_spawn_id "" + } + + # Run simavr. + set cmd "spawn -noecho ${simavr_path} --mcu ${simavr_mcu} -g $file" + verbose -log "Spawning simavr: $cmd" + eval $cmd + set simavr_spawn_id $spawn_id + gdb_expect { + -i $simavr_spawn_id -re ".*avr_gdb_init listening on port 1234" {} + timeout { error "unable to start simavr" } + } + + # Connect to simavr. + send_gdb "target remote :1234\n" + gdb_expect { + -re ".*Remote debugging using :1234.*\[\r\n\]+$gdb_prompt $" {} + } + + return 0 +} -- 2.26.2