Re: [PATCH, testsuite] Allow function arguments in bp print match in selftest_setup

[Tom de Vries <tdevries@suse.de>]

On 06/14/2018 12:45 PM, Pedro Alves wrote:
> On 06/14/2018 11:21 AM, Tom de Vries wrote:
> 
>>> [1] Funny, it passes for me (with the fix for stopping at captured_main),
>>> because the pattern below the one you're touching matches:
>>>
>>> 	-re "Starting program.*Breakpoint \[0-9\]+,.* at .*main.c:.*$function.*$gdb_prompt $" {
>>> 	    # $function may be inlined, so the program stops at the line
>>> 	    # calling $function.
>>> 	    pass "$description"
>>> 	}
>>>
>>> and it only happens to match because captured_main calls
>>> captured_main_1 first thing, which coincidentally
>>> matches "$function.*":
>>>
>>>  Breakpoint 1, captured_main (data=<optimized out>) at gdb/binutils-gdb/src/gdb/main.c:1147
>>>  1147      captured_main_1 (context);
>>>
>>> That would probably be better "$function .*", with a space,
>> Right, I observed that as well, and was thinking of this type of fix.

> Please don't be shy about stating those things upfront, makes
> review easier.  :-)
> 

Ack, yeah, sorry about that. I'm currently visiting the Nuremberg
office, so I'm a bit more distracted than usual.

Thanks,
- Tom