From: Pedro Alves <palves@redhat.com>
To: Pedro Franco de Carvalho <pedromfc@linux.vnet.ibm.com>,
gdb-patches@sourceware.org
Cc: uweigand@de.ibm.com
Subject: Re: [PATCH 4/4] Variable size for regs mask in collection list
Date: Tue, 26 Jun 2018 16:58:00 -0000 [thread overview]
Message-ID: <260c8d22-f46d-8c59-28df-fae45a3506ab@redhat.com> (raw)
In-Reply-To: <20180620210855.6385-5-pedromfc@linux.vnet.ibm.com>
Hi,
I quickly skimmed this one and noticed a couple formatting nits,
mentioned below.
On 06/20/2018 10:08 PM, Pedro Franco de Carvalho wrote:
> @@ -1086,9 +1087,21 @@ collection_list::add_static_trace_data ()
> }
>
> collection_list::collection_list ()
> - : m_regs_mask (),
> - m_strace_data (false)
> + : m_strace_data (false)
> {
> + /* Guess the number of bytes needed for the register mask. If it's
> + too low, it will be expanded in add_register. If it's too high,
> + stringify will ignore the extra bytes.
Double-space after the periods of the first two sentences.
> +
> + The mask shouldn't include pseudoreg numbers, but
> + encode_actions_1 currently doesn't handle remote register numbers
> + and pseudoregs properly for tracepoint actions that don't
> + generate an AX (e.g. "collect $<pseudoreg>"). */
> + int num_regs = gdbarch_num_regs (target_gdbarch ())
> + + gdbarch_num_pseudo_regs (target_gdbarch ());
Wrap in parens so that emacs tab-indents the second line
under gdbarch:
int num_regs = (gdbarch_num_regs (target_gdbarch ())
+ gdbarch_num_pseudo_regs (target_gdbarch ()));
Thanks,
Pedro Alves
next prev parent reply other threads:[~2018-06-26 16:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 21:09 [PATCH 0/4] Allow larger sizes for tracepoint register masks Pedro Franco de Carvalho
2018-06-20 21:09 ` [PATCH 4/4] Variable size for regs mask in collection list Pedro Franco de Carvalho
2018-06-25 10:38 ` Ulrich Weigand
2018-06-26 16:58 ` Pedro Alves [this message]
2018-06-26 18:52 ` Pedro Franco de Carvalho
2018-06-20 21:09 ` [PATCH 3/4] Use get_remote_packet_size in download_tracepoint Pedro Franco de Carvalho
2018-06-25 10:37 ` Ulrich Weigand
2018-06-25 20:51 ` Pedro Franco de Carvalho
2018-06-26 10:52 ` Ulrich Weigand
2018-06-26 16:53 ` Pedro Alves
2018-06-26 18:49 ` Pedro Franco de Carvalho
2018-06-20 21:09 ` [PATCH 1/4] Fix indentation in remote_target::download_tracepoint Pedro Franco de Carvalho
2018-06-25 10:32 ` Ulrich Weigand
2018-06-20 21:10 ` [PATCH 2/4] Remove trailing '-' from the last QTDP action packet Pedro Franco de Carvalho
2018-06-25 10:33 ` Ulrich Weigand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=260c8d22-f46d-8c59-28df-fae45a3506ab@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedromfc@linux.vnet.ibm.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).