From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84506 invoked by alias); 26 Jun 2018 16:58:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 84496 invoked by uid 89); 26 Jun 2018 16:58:46 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=periods X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Jun 2018 16:58:44 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 00D93402312B; Tue, 26 Jun 2018 16:58:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5C2CD1C66E; Tue, 26 Jun 2018 16:58:41 +0000 (UTC) Subject: Re: [PATCH 4/4] Variable size for regs mask in collection list To: Pedro Franco de Carvalho , gdb-patches@sourceware.org References: <20180620210855.6385-1-pedromfc@linux.vnet.ibm.com> <20180620210855.6385-5-pedromfc@linux.vnet.ibm.com> Cc: uweigand@de.ibm.com From: Pedro Alves Message-ID: <260c8d22-f46d-8c59-28df-fae45a3506ab@redhat.com> Date: Tue, 26 Jun 2018 16:58:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180620210855.6385-5-pedromfc@linux.vnet.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-06/txt/msg00620.txt.bz2 Hi, I quickly skimmed this one and noticed a couple formatting nits, mentioned below. On 06/20/2018 10:08 PM, Pedro Franco de Carvalho wrote: > @@ -1086,9 +1087,21 @@ collection_list::add_static_trace_data () > } > > collection_list::collection_list () > - : m_regs_mask (), > - m_strace_data (false) > + : m_strace_data (false) > { > + /* Guess the number of bytes needed for the register mask. If it's > + too low, it will be expanded in add_register. If it's too high, > + stringify will ignore the extra bytes. Double-space after the periods of the first two sentences. > + > + The mask shouldn't include pseudoreg numbers, but > + encode_actions_1 currently doesn't handle remote register numbers > + and pseudoregs properly for tracepoint actions that don't > + generate an AX (e.g. "collect $"). */ > + int num_regs = gdbarch_num_regs (target_gdbarch ()) > + + gdbarch_num_pseudo_regs (target_gdbarch ()); Wrap in parens so that emacs tab-indents the second line under gdbarch: int num_regs = (gdbarch_num_regs (target_gdbarch ()) + gdbarch_num_pseudo_regs (target_gdbarch ())); Thanks, Pedro Alves