From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id B0F4A3858D28 for ; Thu, 21 Jul 2022 12:55:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B0F4A3858D28 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id F07E61F86C; Thu, 21 Jul 2022 12:55:30 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id D3DE013AB5; Thu, 21 Jul 2022 12:55:30 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id tKKNMsJM2WLoFwAAMHmgww (envelope-from ); Thu, 21 Jul 2022 12:55:30 +0000 Content-Type: multipart/mixed; boundary="------------QVEFiphQ4YOz6kikwyxgmOzb" Message-ID: <262ad25a-f86d-628b-50b5-17a2c0131fd1@suse.de> Date: Thu, 21 Jul 2022 14:55:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH][gdb] Fix python selftest with python 3.11 Content-Language: en-US To: Mark Wielaard Cc: gdb-patches@sourceware.org, Kevin Buettner References: <20220721111316.GA23728@delia.home> <20220721114239.GB7014@gnu.wildebeest.org> <716feba4-7ca1-dc46-12b3-e7a895956d8b@suse.de> From: Tom de Vries In-Reply-To: X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, NICE_REPLY_A, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Jul 2022 12:55:33 -0000 This is a multi-part message in MIME format. --------------QVEFiphQ4YOz6kikwyxgmOzb Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/21/22 14:36, Mark Wielaard wrote: > Hi Tom, > > On Thu, Jul 21, 2022 at 02:06:09PM +0200, Tom de Vries wrote: >>> It seems the line number is really irrelevant here for where exactly >>> the KeyboardInterrupt took place. So the patch looks good to me. >>> >> >> Thanks for the review. >> >>> Note that there is a gdb-try-rawhide-x86_64 builder, so you can also >>> test by pushing this to a git users/vries/try-xxx branch. >> >> I've tried that, and it went fine, so I've pushed this (after fixing a >> trivial formatting issue, not reposting). > > I am afraid the trivial formatting fix accidentially introduced an > extra space before KeyboardInterrupt: > > " KeyboardInterrupt\n" should be "KeyboardInterrupt\n" > Thanks for noticing that. Fixed by this commit (also tested using the try-buildbot, and this time, committed what I actually tested). Committed. Thanks, - Tom --------------QVEFiphQ4YOz6kikwyxgmOzb Content-Type: text/x-patch; charset=UTF-8; name="0001-gdb-python-Fix-typo-in-test_python.patch" Content-Disposition: attachment; filename="0001-gdb-python-Fix-typo-in-test_python.patch" Content-Transfer-Encoding: base64 W2dkYi9weXRob25dIEZpeCB0eXBvIGluIHRlc3RfcHl0aG9uCgpGaXggdHlwbyBpbiByZWZf b3V0cHV0XzAgdmFyaWFibGUgaW4gdGVzdF9weXRob24uCgpUZXN0ZWQgYnkgcnVubmluZyB0 aGUgc2VsZnRlc3Qgb24geDg2XzY0LWxpbnV4IHdpdGggcHl0aG9uIDMuMTEuCgotLS0KIGdk Yi9weXRob24vcHl0aG9uLmMgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24o KyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9nZGIvcHl0aG9uL3B5dGhvbi5jIGIv Z2RiL3B5dGhvbi9weXRob24uYwppbmRleCBjMDMxMjQxM2E3My4uYzdkNDE1N2I3MGMgMTAw NjQ0Ci0tLSBhL2dkYi9weXRob24vcHl0aG9uLmMKKysrIGIvZ2RiL3B5dGhvbi9weXRob24u YwpAQCAtMjI0Miw3ICsyMjQyLDcgQEAgdGVzdF9weXRob24gKCkKICAgICBTRUxGX0NIRUNL IChzYXdfZXhjZXB0aW9uKTsKICAgICBzdGQ6OnN0cmluZyByZWZfb3V0cHV0XzAgKCJUcmFj ZWJhY2sgKG1vc3QgcmVjZW50IGNhbGwgbGFzdCk6XG4iCiAJCQkgICAgICAiICBGaWxlIFwi PHN0cmluZz5cIiwgbGluZSAwLCBpbiA8bW9kdWxlPlxuIgotCQkJICAgICAgIiBLZXlib2Fy ZEludGVycnVwdFxuIik7CisJCQkgICAgICAiS2V5Ym9hcmRJbnRlcnJ1cHRcbiIpOwogICAg IHN0ZDo6c3RyaW5nIHJlZl9vdXRwdXRfMSAoIlRyYWNlYmFjayAobW9zdCByZWNlbnQgY2Fs bCBsYXN0KTpcbiIKIAkJCSAgICAgICIgIEZpbGUgXCI8c3RyaW5nPlwiLCBsaW5lIDEsIGlu IDxtb2R1bGU+XG4iCiAJCQkgICAgICAiS2V5Ym9hcmRJbnRlcnJ1cHRcbiIpOwo= --------------QVEFiphQ4YOz6kikwyxgmOzb--