From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 70635 invoked by alias); 26 Jun 2018 19:08:38 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 70620 invoked by uid 89); 26 Jun 2018 19:08:37 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=ptype X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 26 Jun 2018 19:08:35 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w5QJ8Slo031467 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 26 Jun 2018 15:08:33 -0400 Received: by simark.ca (Postfix, from userid 112) id 851911EF28; Tue, 26 Jun 2018 15:08:28 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 86B9C1E08D; Tue, 26 Jun 2018 15:08:27 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 26 Jun 2018 19:08:00 -0000 From: Simon Marchi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [RFA 2/2] Support ptype/o in Rust In-Reply-To: <20180623202227.17259-3-tom@tromey.com> References: <20180623202227.17259-1-tom@tromey.com> <20180623202227.17259-3-tom@tromey.com> Message-ID: <264bed6a37ca5474bfb51565789905bf@polymtl.ca> X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00624.txt.bz2 On 2018-06-23 16:22, Tom Tromey wrote: > @@ -674,16 +683,41 @@ rust_print_struct_def (struct type *type, const > char *varstring, > > if (TYPE_NFIELDS (type) == 0 && !is_tuple) > return; > - if (for_rust_enum) > + if (for_rust_enum && !flags->print_offsets) > fputs_filtered (is_tuple_struct ? "(" : "{", stream); > else > fputs_filtered (is_tuple_struct ? " (\n" : " {\n", stream); > > + // When printing offsets, we rearrange the fields into storage > + // order. This lets us show holes more clearly. We work using > + // field indices here because it simplifies calls to > + // print_offset_data::update below. Use /**/ comments. Otherwise, both patches LGTM. Simon