From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 127962 invoked by alias); 17 Apr 2018 16:12:05 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 127949 invoked by uid 89); 17 Apr 2018 16:12:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-25.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=ham version=3.3.2 spammy=Hx-languages-length:1414, matrix, impression, readable X-HELO: mail.baldwin.cx Received: from bigwig.baldwin.cx (HELO mail.baldwin.cx) (96.47.65.170) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Apr 2018 16:12:00 +0000 Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id CC62610AFAD; Tue, 17 Apr 2018 12:11:58 -0400 (EDT) From: John Baldwin To: gdb-patches@sourceware.org Cc: Pedro Alves Subject: Re: [PATCH 31/40] target_ops/C++: Base FreeBSD target Date: Tue, 17 Apr 2018 16:12:00 -0000 Message-ID: <2651054.rGX2nUqyEc@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <20180414190953.24481-32-palves@redhat.com> References: <20180414190953.24481-1-palves@redhat.com> <20180414190953.24481-32-palves@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-IsSubscribed: yes X-SW-Source: 2018-04/txt/msg00341.txt.bz2 On Saturday, April 14, 2018 08:09:44 PM Pedro Alves wrote: > The > > $architecture x NetBSD/OpenBSD/FreeBSD > > support matrix complicates things a bit. There's common BSD target > code, and there's common architecture-specific code shared between the > different BSDs. Current, all that is stiched together to form a final > target, via the i386bsd_target, x86bsd_target, fbsd_nat_add_target > functions etc. > > Introduces a fbsd_nat_target base/prototype target. To be used in > following patches. I will do some tests of FreeBSD/amd64 first and let you know what I find. One small thing I noticed: > diff --git a/gdb/fbsd-nat.h b/gdb/fbsd-nat.h > index 8326b96db7..a4418bb8f8 100644 > --- a/gdb/fbsd-nat.h > +++ b/gdb/fbsd-nat.h > + > +#ifdef PL_FLAG_EXEC > + int insert_exec_catchpoint (int) override; > + int remove_exec_catchpoint (int) override; > +#endif > + > +#ifdef HAVE_STRUCT_PTRACE_LWPINFO_PL_SYSCALL_CODE > + int set_syscall_catchpoint (int, bool, int, gdb::array_view) > + override; > +#endif /* HAVE_STRUCT_PTRACE_LWPINFO_PL_SYSCALL_CODE */ > + > +#endif /* PT_LWPINFO */ > +}; Do we want to be consistent about whether or not to have comments for #endif's? Most in this change don't but these two do. (Also, my initial impression is that the #ifdef's are more readable in this version than the current code) -- John Baldwin