From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id A10E0385782C for ; Wed, 4 May 2022 12:17:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A10E0385782C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 244CHllp021773 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 4 May 2022 08:17:52 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 244CHllp021773 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 55E651E00E; Wed, 4 May 2022 08:17:47 -0400 (EDT) Message-ID: <269e595f-0263-82f0-6327-fa366d8bdbb6@polymtl.ca> Date: Wed, 4 May 2022 08:17:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH v2 1/2] gdb/remote: iterate on pspace inferiors in remote_new_objfile Content-Language: en-US To: Pedro Alves , gdb-patches@sourceware.org References: <20220430032115.524232-1-simon.marchi@polymtl.ca> <20220430032115.524232-2-simon.marchi@polymtl.ca> <3b089300-e2bf-ada5-f5f5-1f4a3d54c3ad@palves.net> From: Simon Marchi In-Reply-To: <3b089300-e2bf-ada5-f5f5-1f4a3d54c3ad@palves.net> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 4 May 2022 12:17:47 +0000 X-Spam-Status: No, score=-3033.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2022 12:17:55 -0000 On 2022-05-04 08:04, Pedro Alves wrote: > On 2022-04-30 04:21, Simon Marchi via Gdb-patches wrote: > >> To fix this, make remote_new_objfile iterate on all inferiors bound to >> the affected program space. Remove the target_has_execution check from >> remote_check_symbols, replace it with an assert. All callers must >> ensure that the current inferior has execution before calling it. > > OK. Thanks, pushed. Simon