Re: [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile

[Luis Machado <luis.machado@arm.com>]

On 9/13/22 16:11, Simon Marchi wrote:
>> I think it should be OK to remove these files (Linux doesn't support m-profiles, so it is unlikely this will get
>> used in the near future). We should add documentation about the feature, its registers and its purpose somewhere,
>> either in the code or in the manual. I can do that.
> This would be the right page, I suppose:
> 
> https://sourceware.org/gdb/current/onlinedocs/gdb/ARM-Features.html#ARM-Features
> 
>> Otherwise the changes look OK to me. Watch out for the dynamically-generated descriptions (like aarch64-sve.c). I plan
>> to submit a patch to remove aarch64-tls.xml and make aarch64-tls.c generate the feature dynamically.
>>
>> Is there something we should be aware of when adding such files that don't have corresponding .xml ones?
> 
> I don't think so.
> 
> I wish that the generated and non-generated ones were separated (perhaps
> put the generated ones in a "generated" directory), so it's easier to
> remove them, to force-regenerate them.  And maybe "make clean" in
> features/ could remove them too.  But that's not a prerequisite for what
> you want to do.

Sounds reasonable to me. I'll put on my list to do it.