From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2042.outbound.protection.outlook.com [40.107.20.42]) by sourceware.org (Postfix) with ESMTPS id 79C093858D1E for ; Tue, 13 Sep 2022 15:19:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 79C093858D1E ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=LxFPc8RanhBtDj+Abco/ALaiG1DSHG80aRGe2GFbGVlvNCQnkeisirWPBTQxDe6Ce3IYxcYE40aI7ZWzK0mrRtBlW3hYuP9Jiv8G0ak7pMtNEkZ4ICm775DSpfomoa/af4wjvadkzdtTpNLVkKZ+iRi9oGnn7O/mwN5s+zeHesxiyo5g3zWgzvatYA0HfvkPQRuFTSd7yzEP2TvhHooG1Dku6+jqtoly04uNoAuCgesKav7vh+3NebOVNkDn1pjXVr+2UHWgi5Ue9lL1gVRHoK1e6yTBwTRzUwtHR6IbvvFiWHZIX9w9xBBM5Hh/7M30ERi2ncQAZ2oPypyEkB//VQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cx6GdOqEV6Si0JxQYXr1nBdI49P8e4ovfaDuxq/ACnI=; b=UiK17ckLfrFIJrKTizXg06qrqsPI6D65ZQjSnqzVTgCbTfyW8gOnKHFpiHSVT87jbLWRsf0QW2KpdjjtRZnp1oJKJV3DuykP6fobX8nhOHWrmjW1HXSrobxvMnhYgJQ2oWVLjJi0LqaXCeaaW03bMVRMh/43qO6Hfb6N9qa1xx5ZSJTtgnh9ZvasIS6deR4tK06SDH6vPpVXxCmQD68SEj76p7CHn0kY/zBHEESF8sZ0StDw3foKPOJToigbjOFeQ3zq9rx+BWcY2cWynYF53ysQezal5ZngyA7piES7eNg0rBhKqRUsvvORFiMqq55HAAHVV+3jLnxQnikV2RldYg== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) Received: from AS4P191CA0026.EURP191.PROD.OUTLOOK.COM (2603:10a6:20b:5d9::17) by VE1PR08MB5742.eurprd08.prod.outlook.com (2603:10a6:800:1a9::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.14; Tue, 13 Sep 2022 15:19:52 +0000 Received: from VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:5d9:cafe::12) by AS4P191CA0026.outlook.office365.com (2603:10a6:20b:5d9::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.20 via Frontend Transport; Tue, 13 Sep 2022 15:19:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by VE1EUR03FT055.mail.protection.outlook.com (10.152.19.158) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.13 via Frontend Transport; Tue, 13 Sep 2022 15:19:52 +0000 Received: ("Tessian outbound 88978e6d60db:v124"); Tue, 13 Sep 2022 15:19:51 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 6c05caa3ac4c45b1 X-CR-MTA-TID: 64aa7808 Received: from 3ab1a90b86b4.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 06A0A27E-7054-46DD-863A-FFD0215BC3EB.1; Tue, 13 Sep 2022 15:19:45 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 3ab1a90b86b4.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Tue, 13 Sep 2022 15:19:45 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=og3SJ9R3B1FkF7Zaq1gZEsdbGlDcXVdC5307AHKDuoe5J5ItZIxW0xioLvUP6WkjBBHiRVrzFHYCvjLzhdCkcDcTOG0JVRq8H8P/qWKv1y8PThcHMotIdYVTjScbAxKwmOgx7NPHr+Fhe2gy38vSIk53lgYJPKZ+t5PsI02/0SxkNORAz+6EbUes/Rw2FpE1vG88Obo+C8btmd3qZojrMEgbor7EpF9PAkYkzMJ0gnrSnxZmG8rnZXeO/xYPVUA6y/7mkzzCDETXSkBAHMfvEJA1n1L3BD1ASlZV7F09dHLC00kQCzQwAFg+1qkjSRE4bUZD6wt5ZwjvItV9tfuC2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cx6GdOqEV6Si0JxQYXr1nBdI49P8e4ovfaDuxq/ACnI=; b=GQohoFXCrHwB/3XiNEmhtRg8LEi6dTs835VSKkS3xn70ESOAxCnE3zxSvKwEcrzFSPLQQGFiniSEEfFCO8w3L444WsaZg7la6AI7p66N2jqccaHmKTEk3V/gWPRY7L7h1+qxZ2kl67GYJw4JAJLmKqx8SCc1EivpiEhBEeDXFdAXJa12DMDnzQpLsnCxkWmOV2e1SfjD4LJaN54maitm1KnaClt4Ct/tRVUAen0E9nUktmjCh+Wzuhbqg2JyOMU7gzisZgqG4Rza2Q/tGyjKUXfzXLKxvMk76tJDoBVX3VHN6BhqdigWyOLFeILgKJmqsWdLdSm6dWgs1spFhTPM1g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AM8PR08MB6594.eurprd08.prod.outlook.com (2603:10a6:20b:36a::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5612.18; Tue, 13 Sep 2022 15:19:44 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c5f9:a25b:a5f2:6094%5]) with mapi id 15.20.5612.022; Tue, 13 Sep 2022 15:19:43 +0000 Message-ID: <26f20e7c-cfea-2e8d-6528-72e998cae134@arm.com> Date: Tue, 13 Sep 2022 16:19:42 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/2] cleanup: Add missing feature/ XML files to Makefile Content-Language: en-US To: Simon Marchi , Keith Seitz , gdb-patches@sourceware.org References: <20220912224733.2962282-1-keiths@redhat.com> <383112d6-4d64-38e5-9e77-3f46b845e494@simark.ca> <77ffceca-e0c9-ed22-162f-cbf2f904aefa@redhat.com> From: Luis Machado In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO2P123CA0029.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600::17) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AM8PR08MB6594:EE_|VE1EUR03FT055:EE_|VE1PR08MB5742:EE_ X-MS-Office365-Filtering-Correlation-Id: 7671efe6-6eca-4b37-6338-08da959b67e1 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: AU055/DAa5e5EA+zE4CuCZc6RH9sMJAE9emZbddLnAGxTKKtTgWNK4j5qCrFpesYI282DLxPPDzR3Es7xh5viB0hDW4dDZS52GXWrzrzJtm3GFkN5AAPh5yNOh3dyjIm4c5oLv6FM1W/Kr+fyC8wB3JvaVaynUlbSm53i2Sejymhdif1jRFR5ECVjU5Amypm65dEWhoHAMrVXLSyd3YLUli3w24NswijRL+bs1tWz+IV+GhORzqT/JlR/u2fNCdDcSOEf9La3Mh5V1reea4jrLFV1Np0Muoh320ESxnmpGv2G2IFtQZuQD4e98k/I7Pha2LrtMdkZBp/tfGgn1Hjc/iryXQO++Rvw/nbNUcYI4t4y1/l/UiRpjbRSNjgRYsCvQdISX9+Hrvskg97s4SqwAAlohyY63YLiLonNGbS9YWaQarm7cd2t7h5KbDdYK4qldM1FnGfMMazTltg36TG5ipZgARKQtTVuV1uYTdD90lEzm5ytl/ngbNxMwPn8XolZ/A+yRlb7oOKFpd1jXm+0RIoqGL+PUR0TQMwrioCEDfcnFJ1JMdcSHGT7sYhs1ITtAYZxGFysREmbCnvlTkNyzH1/zE+8jY65It8RtJxYL+Eez+1b7pCjAPziUCXerTuIC7RRz6UWKIsBN4AULAjL6CVyFr/sWfRG1TRVRhvgtFvBuxa4Xkyv8FUy0805Rkl7COABH4NnXYXQGyXve9JR71lzFT/ZCdnyF3tMKce6sJkiWdhV3pn2tcu2qFW3XwP0iIdddmIuzxqSfocWo7YvQxiFtljHTrzc/6ujffgvAu63jR6DHbSa6TtMWyl7GJU X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(4636009)(396003)(136003)(346002)(366004)(376002)(39860400002)(451199015)(66476007)(53546011)(66946007)(8676002)(6512007)(31686004)(5660300002)(2616005)(66556008)(38100700002)(110136005)(186003)(41300700001)(44832011)(31696002)(86362001)(6486002)(83380400001)(478600001)(966005)(316002)(36756003)(26005)(2906002)(6506007)(8936002)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR08MB6594 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 5e1f1e60-ae8f-472b-dfeb-08da959b62dd X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Gj7aENScZxP8aC1vP0xeeUN+4PmZfJqfrMxrRjkj7xe0mb6a6MUZB6JV8WHnnnJB3kHuK14bGBZjtcSnXvUP0nMbI0ipYbOj7bOsDgBLbvhalGe3QpbYsaBeE/T8s6/UGsyE90VAKj2+dQQkLzVEolFMr5zxRQ6khlQkZHvLdxgsB8rZ5t0DWGBVUZQdm45TVvvdO43G3FQCJAwtGVDYPaf3zNcqIz26l4L1RLlrurlpcqonFn7pgVfhOssYPkjjMcsK9HLzBtkM4wQR9lhySQT/EpC7cCUkDAXN4peYWpf82jHZTn3tQzcex1Q8DLDRNQhmwt4UShoAh4b8f/Vpqf88LNG5vMH5qDrE5ZiL+v+tc3Hpox503puY+aA1xlZSMwko6eIIBIa/PAsZDuJ7q1BbDtI9SOhg4Oqt+as+vZO+mL7lpjdx9xDieNt7NUYjrUKzwRG+jEbeEHB/8uzYRzrz4jTYN14mpqYmRk4PuPk/1DqWtsJbF236OtA9WFQfF2Rhnlh1NBm7gC7Ews6cPL4fj7tad01xdVk8unXsZmRT3ErF6OMt0oErlB9oVrd821gbFUrTfI8HjlBmQMPmsCa++NcgkjCW3QW7UR1cdik77OgiQdt22ueI0XJ3zIciPOU3AHubHO4DWCdXDJhD1sGPmFlLUIvOjGYuzeOYoUtP95xiFqIOZ5Y7PDpucgpfdgXXjlqMNFzO94kqQq8VwmwlLXpQhkrMFMwl6qYOBPfcrMibYTBTce08lNukGx0fHSFir0q11690lr9ZXWZ9hMOwnSm+051+0z+nrDtsgzw6yeA4z6fJuflj+6OImxDC X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230022)(4636009)(346002)(136003)(396003)(376002)(39860400002)(451199015)(46966006)(40470700004)(36840700001)(316002)(186003)(47076005)(31696002)(83380400001)(36756003)(2616005)(53546011)(41300700001)(31686004)(356005)(8676002)(110136005)(336012)(82740400003)(81166007)(36860700001)(2906002)(5660300002)(40480700001)(86362001)(82310400005)(6486002)(6512007)(478600001)(44832011)(26005)(40460700003)(966005)(70206006)(70586007)(8936002)(6506007)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Sep 2022 15:19:52.0546 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7671efe6-6eca-4b37-6338-08da959b67e1 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: VE1EUR03FT055.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5742 X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Sep 2022 15:19:57 -0000 On 9/13/22 16:11, Simon Marchi wrote: >> I think it should be OK to remove these files (Linux doesn't support m-profiles, so it is unlikely this will get >> used in the near future). We should add documentation about the feature, its registers and its purpose somewhere, >> either in the code or in the manual. I can do that. > This would be the right page, I suppose: > > https://sourceware.org/gdb/current/onlinedocs/gdb/ARM-Features.html#ARM-Features > >> Otherwise the changes look OK to me. Watch out for the dynamically-generated descriptions (like aarch64-sve.c). I plan >> to submit a patch to remove aarch64-tls.xml and make aarch64-tls.c generate the feature dynamically. >> >> Is there something we should be aware of when adding such files that don't have corresponding .xml ones? > > I don't think so. > > I wish that the generated and non-generated ones were separated (perhaps > put the generated ones in a "generated" directory), so it's easier to > remove them, to force-regenerate them. And maybe "make clean" in > features/ could remove them too. But that's not a prerequisite for what > you want to do. Sounds reasonable to me. I'll put on my list to do it.