From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 8710B3858C62 for ; Mon, 28 Nov 2022 18:30:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8710B3858C62 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 2ASITtlc006659 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 28 Nov 2022 13:29:59 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 2ASITtlc006659 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1669660200; bh=v1XFxo//3MIBMjTBhz0zbXlYILHC7A4cXAKtlH1UsxE=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=L/TIzdnqXLIBZTtFxhkmef8TGL9xWeFhL/7qcK9VmDM79hXBXcbppoHC04IViCVUq JP9QoNaIcvrV91BVDPW8mypXCougMU4yd4LNzYR8uKtGBLuOeo9gPwwZdM7P5/lvGO TkO1Ewspa9OtImblHyl80+XTKHhdIAGP8zSJtbB4= Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id D8F261E0D3; Mon, 28 Nov 2022 13:29:54 -0500 (EST) Message-ID: <26f7b567-98d1-9b55-622b-fa882de6fa8c@polymtl.ca> Date: Mon, 28 Nov 2022 13:29:54 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 1/2] gdb: merge solib-frv aix-solib debug options into "set/show debug solib" Content-Language: en-US To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20221128170049.1094477-1-simon.marchi@polymtl.ca> <83zgcbm1pv.fsf@gnu.org> From: Simon Marchi In-Reply-To: <83zgcbm1pv.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Mon, 28 Nov 2022 18:29:55 +0000 X-Spam-Status: No, score=-3032.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/28/22 12:24, Eli Zaretskii wrote: >> Cc: Simon Marchi >> Date: Mon, 28 Nov 2022 12:00:48 -0500 >> From: Simon Marchi via Gdb-patches >> >> solib implementations are typically used one at a time. So it will be >> rare that you will want to enable debug for one solib kind, and >> absolutely want to keep the others disabled. To make things simpler, >> instead of adding separate variables / macros / commands for each solib >> implementation, merge the existing ones (frv and aix) into a unified >> "set/show debug solib", with the solib_debug_printf macro. >> >> Change-Id: I6e18bbc7401724f37ae66681badb079d75ecf7fa >> --- >> gdb/NEWS | 12 ++++++ >> gdb/doc/gdb.texinfo | 18 +++------ >> gdb/solib-aix.c | 39 +++---------------- >> gdb/solib-frv.c | 95 +++++++++++---------------------------------- >> gdb/solib.c | 16 +++++--- >> gdb/solib.h | 12 ++++++ >> 6 files changed, 68 insertions(+), 124 deletions(-) > > OK for the documentation parts, thanks. > > I wonder what the others think about removing those two commands? Do we > have any policy regarding that? Maybe leave them as aliases for the new > command? Tom mentioned he's fine with it here: https://inbox.sourceware.org/gdb-patches/94b7d01e-509f-eeaa-ff04-90be8d860868@polymtl.ca/T/#m7f63f08de9db666a51ebbe165a916c51000736c3 Like I said earlier, I believe it's fine to change these debug commands. They exist essentially for people debugging some trouble with GDB itself, not for the everyday user. I think it's fine to consider them as maintenance commands (and even move them to the maint prefix one day, as Tom mentioned). Given I see them as maintenance commands, I'd rather not add aliases, unless you have strong feelings about it. Simon