From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 110D03858D32 for ; Thu, 1 Dec 2022 18:34:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 110D03858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6775C1E0D3; Thu, 1 Dec 2022 13:34:47 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1669919687; bh=cgJkztRLc+SAO/7vdp5oI9iiI3iYt/AxNm0S1WF/C6o=; h=Date:Subject:To:References:From:In-Reply-To:From; b=k3NvarbDbfF3UqVUJH35Cw4gHoBzKOKsKFpn+Sp8/WCYkTcJv/Qriy3NPGeNzGxP/ QyMXJyuCaRANWxuulKMnJCNw21VlOvGqeAnum5uPsBxXt+X4uOGG4c0CJjMtXuFn04 /dUYByQ4INspeE30y4YtlAoVjrnGmXXCVtLaPuQc= Message-ID: <2715d293-122f-10ff-e631-38b9c9a70562@simark.ca> Date: Thu, 1 Dec 2022 13:34:46 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] Remove call to registers_changed from windows-nat.c Content-Language: fr To: Tom Tromey , gdb-patches@sourceware.org References: <20221201182857.2591740-1-tromey@adacore.com> From: Simon Marchi In-Reply-To: <20221201182857.2591740-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/1/22 13:28, Tom Tromey via Gdb-patches wrote: > I noticed that windows_nat_target::interrupt calls registers_changed. > However, I don't think there's any reason to do this, because this > will happen automatically when the inferior stop is processed. > --- > gdb/windows-nat.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/gdb/windows-nat.c b/gdb/windows-nat.c > index 17422e15f80..4b0760c5804 100644 > --- a/gdb/windows-nat.c > +++ b/gdb/windows-nat.c > @@ -2881,7 +2881,6 @@ windows_nat_target::interrupt () > DEBUG_EVENTS ("GenerateConsoleCtrlEvent (CTRLC_EVENT, 0)"); > CHECK (GenerateConsoleCtrlEvent (CTRL_C_EVENT, > windows_process.current_event.dwProcessId)); > - registers_changed (); /* refresh register state */ > } > > /* Helper for windows_xfer_partial that handles memory transfers. > -- > 2.34.3 > Makes sense to me, Approved-By: Simon Marchi Simon