From: Simon Marchi <simark@simark.ca>
To: Jameson Nash <vtjnash@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: define COFF file offsets with file_ptr
Date: Fri, 27 Nov 2020 15:55:39 -0500 [thread overview]
Message-ID: <271c1246-2c36-accc-b1c7-3340a71993fb@simark.ca> (raw)
In-Reply-To: <CADnnjUXKxJQRDSr_S_b=LxHAOwaj7iyUVcGGWSz-f4B8=bK67g@mail.gmail.com>
On 2020-11-27 3:49 p.m., Jameson Nash wrote:
> It's (currently) computed as the difference of two file_ptr values. The result should be positive, certainly, as it's later used as either a file offset (with a printed warning) and as a size_t. But I'm more inclined to keep it common with the other values here, and use `file_ptr`, which is a signed integer type like `off_t` and `ssize_t`.
Ok, that's fine with me.
Simon
next prev parent reply other threads:[~2020-11-27 20:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 18:11 Jameson Nash
2020-11-26 18:51 ` Simon Marchi
2020-11-26 21:49 ` Simon Marchi
2020-11-27 20:49 ` Jameson Nash
2020-11-27 20:55 ` Simon Marchi [this message]
2020-12-18 19:12 ` Simon Marchi
-- strict thread matches above, loose matches on Subject: below --
2020-11-27 2:46 Jameson Nash
2020-11-25 19:14 Jameson Nash
2020-11-26 15:30 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=271c1246-2c36-accc-b1c7-3340a71993fb@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=vtjnash@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).