From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 7B7BD385802B
 for <gdb-patches@sourceware.org>; Fri, 27 Nov 2020 20:55:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 7B7BD385802B
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id 1B7131E58D;
 Fri, 27 Nov 2020 15:55:40 -0500 (EST)
Subject: Re: [PATCH] gdb: define COFF file offsets with file_ptr
To: Jameson Nash <vtjnash@gmail.com>
Cc: gdb-patches@sourceware.org
References: <20201126181121.31219-1-vtjnash@gmail.com>
 <2bb948a7-e909-8949-7486-2aec0c4a9ecf@simark.ca>
 <CADnnjUXKxJQRDSr_S_b=LxHAOwaj7iyUVcGGWSz-f4B8=bK67g@mail.gmail.com>
From: Simon Marchi <simark@simark.ca>
Message-ID: <271c1246-2c36-accc-b1c7-3340a71993fb@simark.ca>
Date: Fri, 27 Nov 2020 15:55:39 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CADnnjUXKxJQRDSr_S_b=LxHAOwaj7iyUVcGGWSz-f4B8=bK67g@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Fri, 27 Nov 2020 20:55:42 -0000

On 2020-11-27 3:49 p.m., Jameson Nash wrote:
> It's (currently) computed as the difference of two file_ptr values. The result should be positive, certainly, as it's later used as either a file offset (with a printed warning) and as a size_t. But I'm more inclined to keep it common with the other values here, and use `file_ptr`, which is a signed integer type like `off_t` and `ssize_t`.

Ok, that's fine with me.

Simon