From: Ajit Kumar Agarwal <ajit.kumar.agarwal@xilinx.com>
To: Joel Brobecker <brobecker@adacore.com>,
Michael Eager <eager@eagercon.com>
Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
Vinod Kathail <vinodk@xilinx.com>,
Vidhumouli Hunsigida <vidhum@xilinx.com>,
"Nagaraju Mekala" <nmekala@xilinx.com>
Subject: RE: [Patch, microblaze]: Port of Linux gdbserver
Date: Fri, 12 Sep 2014 08:01:00 -0000 [thread overview]
Message-ID: <273d7e70-1fda-4b70-a987-e6831ef4b12a@BL2FFO11FD032.protection.gbl> (raw)
In-Reply-To: <20140910144313.GP28404@adacore.com>
With feedback comments incorporated, Please find the updated patch.
[Patch, microblaze]: Port of Linux gdbserver
This patch is the port of Linux gdbserver.
gdb/ChangeLog:
2014-10-12 Ajit Agarwal <ajitkum@xilinx.com>
* configure.tgt (build_gdbserver): New Definition.
* features/microblaze-linux-core.xml: New file.
* features/microblaze-linux-stack-protect.xml: New file.
* features/microblaze-linux-stack-protect.c: New file.
gdb/gdbserver/ChangeLog:
* gdbserver/Makefile.in (microblaze-linux.c): New target.
* gdbserver/configure.srv (microblaze*-*-linux*): New target.
* gdbserver/linux-microblaze-low.c: New file.
Signed-off-by:Ajit Agarwal ajitkum@xilinx.com
Thanks & Regards
Ajit
-----Original Message-----
From: Joel Brobecker [mailto:brobecker@adacore.com]
Sent: Wednesday, September 10, 2014 8:13 PM
To: Ajit Kumar Agarwal
Cc: Michael Eager; gdb-patches@sourceware.org; Vinod Kathail; Vidhumouli Hunsigida; Nagaraju Mekala
Subject: Re: [Patch, microblaze]: Port of Linux gdbserver
[with my patch-champion hat]
I can't review the gdbserver Changes, but I can look at the rest.
> ChangeLog:
> 2014-10-09 Ajit Agarwal <ajitkum@xilinx.com>
>
> * configure.host (microblaze): New.
> (microblaze*-*-linux*): New.
> * configure.tgt (build_gdbserver): New Definition.
> * gdbserver/Makefile.in (microblaze-linux.c): New target.
> * gdbserver/configure.srv (microblaze*-*-linux*): New target.
> * gdbserver/linux-microblaze-low.c: New file.
Sorry Ajit. I should have seen this in the previous iteration, but there are a couple more nits in the ChangeLog entry that you'll need to fix.
First, gdb and gdb/gdbserver have distinct ChangeLog files, so you'll need to have 2 ChangeLog entries if you touch both areas at the same time. This means that the filenames in gdbserver should not be prefixed with "gdbserver/" in your ChangeLog entry.
Also, change "ChangeLog:" to "gdb/ChangeLog:" and "gdbserver/ChangeLog:".
Please exclude the configure.host change. This looks unrelated.
> diff --git a/gdb/configure.tgt b/gdb/configure.tgt index
> 01311b2..e4894da 100644
> --- a/gdb/configure.tgt
> +++ b/gdb/configure.tgt
> @@ -343,6 +343,7 @@ microblaze*-linux-*|microblaze*-*-linux*)
> gdb_target_obs="microblaze-tdep.o microblaze-linux-tdep.o microblaze-rom.o \
> monitor.o dsrec.o solib-svr4.o symfile-mem.o linux-tdep.o"
> gdb_sim=../sim/microblaze/libsim.a
> + build_gdbserver=yes
> ;;
> microblaze*-*-*)
> # Target: Xilinx MicroBlaze running standalone diff --git
> a/gdb/gdbserver/Makefile.in b/gdb/gdbserver/Makefile.in index
> 1447e61..b2a01f5 100644
> --- a/gdb/gdbserver/Makefile.in
> +++ b/gdb/gdbserver/Makefile.in
> @@ -153,6 +153,7 @@ SFILES= $(srcdir)/gdbreplay.c $(srcdir)/inferiors.c $(srcdir)/dll.c \
> $(srcdir)/linux-ia64-low.c $(srcdir)/linux-low.c \
> $(srcdir)/linux-m32r-low.c \
> $(srcdir)/linux-m68k-low.c $(srcdir)/linux-mips-low.c \
> + $(srcdir)/linux-microblaze-low.c \
> $(srcdir)/linux-nios2-low.c \
> $(srcdir)/linux-ppc-low.c \
> $(srcdir)/linux-s390-low.c \
> @@ -364,6 +365,7 @@ clean:
> rm -f amd64-mpx.c amd64-mpx-linux.c
> rm -f amd64-avx512.c amd64-avx512-linux.c
> rm -f i386-mmx.c i386-mmx-linux.c
> + rm -f microblaze-linux.c
> rm -f x32.c x32-linux.c
> rm -f x32-avx.c x32-avx-linux.c
> rm -f x32-avx512.c x32-avx512-linux.c
There are indentation errors in the two hunks above. Use tabs.
> @@ -634,6 +636,8 @@ mips64-linux.c : $(srcdir)/../regformats/mips64-linux.dat $(regdat_sh)
> $(SHELL) $(regdat_sh) $(srcdir)/../regformats/mips64-linux.dat
> mips64-linux.c mips64-dsp-linux.c : $(srcdir)/../regformats/mips64-dsp-linux.dat $(regdat_sh)
> $(SHELL) $(regdat_sh) $(srcdir)/../regformats/mips64-dsp-linux.dat
> mips64-dsp-linux.c
> +microblaze-linux.c : $(srcdir)/../regformats/microblaze-with-stack-protect.dat $(regdat_sh)
> + $(SHELL) $(regdat_sh)
> +$(srcdir)/../regformats/microblaze-with-stack-protect.dat
> +microblaze-linux.c
> nios2-linux.c : $(srcdir)/../regformats/nios2-linux.dat $(regdat_sh)
> $(SHELL) $(regdat_sh) $(srcdir)/../regformats/nios2-linux.dat
> nios2-linux.c powerpc-32.c :
> $(srcdir)/../regformats/rs6000/powerpc-32.dat $(regdat_sh) diff --git
> a/gdb/gdbserver/configure.srv b/gdb/gdbserver/configure.srv index
> 679fc9f..16e44ee 100644
> --- a/gdb/gdbserver/configure.srv
> +++ b/gdb/gdbserver/configure.srv
> @@ -194,6 +194,12 @@ case "${target}" in
> srv_linux_usrregs=yes
> srv_linux_thread_db=yes
> ;;
> + microblaze*-*-linux*) srv_regobj=microblaze-linux.o
> + srv_tgtobj="$srv_linux_obj linux-microblaze-low.o"
> + srv_linux_usrregs=yes
> + srv_linux_regsets=yes
> + srv_linux_thread_db=yes
> + ;;
> nios2*-*-linux*) srv_regobj="nios2-linux.o"
> srv_tgtobj="$srv_linux_obj linux-nios2-low.o"
> srv_xmlfiles="nios2-linux.xml"
> diff --git a/gdb/gdbserver/linux-microblaze-low.c
> b/gdb/gdbserver/linux-microblaze-low.c
> new file mode 100644
> index 0000000..b86b4f5
> --- /dev/null
> +++ b/gdb/gdbserver/linux-microblaze-low.c
It looks to me like you have many many trailing spaces in the file you are submitting. Please strip them.
Some lines are too long, also.
--
Joel
next prev parent reply other threads:[~2014-09-12 8:01 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 10:14 Ajit Kumar Agarwal
2014-09-10 13:31 ` Michael Eager
2014-09-10 13:46 ` Joel Brobecker
2014-09-10 14:23 ` Ajit Kumar Agarwal
2014-09-10 14:39 ` Michael Eager
2014-09-10 14:59 ` Ajit Kumar Agarwal
2014-09-10 15:12 ` Ajit Kumar Agarwal
2014-09-10 15:27 ` Michael Eager
2014-09-10 15:30 ` Ajit Kumar Agarwal
2014-09-10 15:35 ` Michael Eager
2014-09-10 15:51 ` Ajit Kumar Agarwal
2014-09-10 14:43 ` Joel Brobecker
2014-09-10 15:04 ` Ajit Kumar Agarwal
2014-09-10 15:54 ` Joel Brobecker
2014-09-10 16:10 ` Ajit Kumar Agarwal
2014-09-12 8:01 ` Ajit Kumar Agarwal [this message]
2014-09-12 8:39 ` Ajit Kumar Agarwal
2014-09-12 15:38 ` Michael Eager
2014-09-16 6:42 ` Ajit Kumar Agarwal
2014-09-16 12:06 ` Michael Eager
2014-09-17 9:36 ` Ajit Kumar Agarwal
2014-09-17 14:12 ` Michael Eager
2014-09-16 17:04 ` Pedro Alves
2014-09-17 6:16 ` Ajit Kumar Agarwal
2014-09-17 8:15 ` Pedro Alves
2014-09-17 8:20 ` Ajit Kumar Agarwal
2014-09-23 12:49 ` Ajit Kumar Agarwal
2014-09-30 11:43 ` Pedro Alves
2014-09-30 13:27 ` Ajit Kumar Agarwal
2014-09-30 13:37 ` Pedro Alves
2014-09-30 14:21 ` Ajit Kumar Agarwal
2014-10-08 13:52 [Patch] Microblaze: " Ajit Kumar Agarwal
2014-10-09 16:29 ` Michael Eager
2014-10-09 18:54 ` Ajit Kumar Agarwal
2014-10-09 23:42 ` Michael Eager
2014-10-13 16:00 ` Ajit Kumar Agarwal
2014-10-13 17:49 ` Michael Eager
2014-10-14 3:03 ` Ajit Kumar Agarwal
2014-10-14 15:07 ` Michael Eager
2014-10-14 15:33 ` Ajit Kumar Agarwal
2014-10-14 15:42 ` Ajit Kumar Agarwal
2014-10-15 13:27 ` Pedro Alves
2014-10-17 19:22 ` Ajit Kumar Agarwal
2014-12-15 18:02 ` Pedro Alves
2014-12-15 18:13 ` Michael Eager
2014-12-18 8:58 ` Ajit Kumar Agarwal
2014-12-18 16:10 ` Michael Eager
2014-12-18 8:57 ` Ajit Kumar Agarwal
2014-12-18 11:28 ` Pedro Alves
2014-12-18 16:53 ` Ajit Kumar Agarwal
2014-12-18 17:40 ` Pedro Alves
2014-12-19 8:27 ` Ajit Kumar Agarwal
2014-12-19 10:56 ` Pedro Alves
2014-12-19 10:26 ` Ajit Kumar Agarwal
2014-12-19 11:02 ` Pedro Alves
2014-12-19 18:06 ` Ajit Kumar Agarwal
2014-11-26 12:13 ` Ajit Kumar Agarwal
2014-12-15 16:08 ` Ajit Kumar Agarwal
2014-10-08 14:59 Ajit Kumar Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=273d7e70-1fda-4b70-a987-e6831ef4b12a@BL2FFO11FD032.protection.gbl \
--to=ajit.kumar.agarwal@xilinx.com \
--cc=brobecker@adacore.com \
--cc=eager@eagercon.com \
--cc=gdb-patches@sourceware.org \
--cc=nmekala@xilinx.com \
--cc=vidhum@xilinx.com \
--cc=vinodk@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).