From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44260 invoked by alias); 15 Nov 2016 15:35:15 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 44243 invoked by uid 89); 15 Nov 2016 15:35:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Nov 2016 15:35:10 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 009B88F275; Tue, 15 Nov 2016 15:35:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAFFZ7PJ006569; Tue, 15 Nov 2016 10:35:08 -0500 Subject: Re: [RFA 11/11] Change python_run_simple_file to use gdbpy_ref To: Tom Tromey References: <1478986125-15122-1-git-send-email-tom@tromey.com> <1478986125-15122-12-git-send-email-tom@tromey.com> <871sygidik.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <274d1efb-9bbf-7d22-1053-0a5ff99ca715@redhat.com> Date: Tue, 15 Nov 2016 15:35:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <871sygidik.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00370.txt.bz2 On 11/12/2016 09:39 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom Tromey writes: > > Tom> + gdb::unique_xmalloc_ptr full_path = tilde_expand (filename); > > This is missing a . > I think if there isn't a win32 buildbot instance, I will just drop this > patch, as I have no way to test it. I'd rather not drop it, since we'll need it in order to get rid of cleanups. I think better would be to push this to a branch, to make it easy for others to try it, and call out for (at least build-) testing help. Actually, you don't really need that -- that WIN32 code should work on Unix as well, it's just not as efficient as the other branch. So you can just hack/invert the #ifndef _WIN32 locally for testing. Thanks, Pedro Alves