From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 05BFD3858C83 for ; Sat, 22 Apr 2023 08:01:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 05BFD3858C83 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B9FE721983; Sat, 22 Apr 2023 08:01:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1682150507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRGiIklDxALU3T6CzsWPtSYyOAxuShpXz/w5wG5+e+Y=; b=M0Ees//BGPoG6QSwM8uNgYJm1bitqMGCKBqZ7zTqV1zVFa40qt2dR9In/1ir1Uu5yZSKSK ZJ5I0FjhRjwryQ6058hqzxtBHA4GOQkPWCtnK7arF71kt5+S0dIFqAhUGd0tJsLK4qcO6G SWv7UboT293CZmOBI8zoR85rKJDBN0I= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1682150507; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRGiIklDxALU3T6CzsWPtSYyOAxuShpXz/w5wG5+e+Y=; b=biko64JrdjvwkqqQI58SNb9HY6Rze442X4/JCcHJj1jdiKsenGdL+dCCTcxA5DcFhu0vVo 7hKdOd7q5kBKd/CA== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 9E7E113499; Sat, 22 Apr 2023 08:01:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id QoGUJWuUQ2SZKgAAMHmgww (envelope-from ); Sat, 22 Apr 2023 08:01:47 +0000 Message-ID: <276f25d7-ab32-268f-0875-70cab6180e8d@suse.de> Date: Sat, 22 Apr 2023 10:01:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3] gdb: Fix false match issue in skip_prologue_using_linetable Content-Language: en-US To: Kevin Buettner , Tom de Vries via Gdb-patches Cc: WANG Rui References: <20230418120939.29102-1-tdevries@suse.de> <1a4148e1-1376-3bc6-e398-4c611922c58f@suse.de> <20230421110346.7ca9b163@f37-zws-nv> From: Tom de Vries In-Reply-To: <20230421110346.7ca9b163@f37-zws-nv> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,KAM_SHORT,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 4/21/23 20:03, Kevin Buettner wrote: > Hi Tom, > > On Tue, 18 Apr 2023 14:15:06 +0200 > Tom de Vries via Gdb-patches wrote: > >> On 4/18/23 14:09, Tom de Vries via Gdb-patches wrote: >>> Co-Authored-By: WANG Rui (fix, tiny change [1]) >>> Co-Authored-By: Tom de Vries (test-case) >>> >>> [1] https://www.gnu.org/prep/maintain/html_node/Legally-Significant.html >> >> I'm not used to deal with these matters, so I'd appreciate some >> review/approval on this. Is my copyright status assessment correct, and >> did I write it up correctly? > > I refreshed my memory via the link you provided above. Based on what > is written there, I conclude that Wang Rui's change is not legally > signficant for copyright purposes. > > Also, I've looked over the Rui's patch as well as your test case, and > it looks good to me. So... > > Approved-by: Kevin Buettner > Hi Kevin, Thanks for review. Committed and also backported to gdb-13-branch, because it was a 12 -> 13 regression. Thanks, - Tom