From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70084.outbound.protection.outlook.com [40.107.7.84]) by sourceware.org (Postfix) with ESMTPS id C4F743853D4D for ; Mon, 21 Nov 2022 14:05:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C4F743853D4D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NGif+Ejy8+OFQ5yug/KcaXv+yoEwwSD0VM9/Y1iPAfw=; b=xVpstgDGTDBaL6Rfqq/fUrAm3tTzNPM/iD7tPXsc5GQV05VeuLO58HXq/K2pENkkcF/7AFpySH8Y5qmWPHNGNwqkFLMHSN5eZzgcvhkZ0EfQ+pDHQ5VaRoIq28F7Q9NaeQoDXDcLIpaaD830c6ndsYArjSD3VpFFIoBK96Kd0bc= Received: from AS9PR06CA0064.eurprd06.prod.outlook.com (2603:10a6:20b:464::34) by DB9PR08MB8360.eurprd08.prod.outlook.com (2603:10a6:10:3d8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov 2022 14:05:10 +0000 Received: from AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com (2603:10a6:20b:464:cafe::80) by AS9PR06CA0064.outlook.office365.com (2603:10a6:20b:464::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.15 via Frontend Transport; Mon, 21 Nov 2022 14:05:09 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT032.mail.protection.outlook.com (100.127.140.65) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5834.8 via Frontend Transport; Mon, 21 Nov 2022 14:05:09 +0000 Received: ("Tessian outbound 58faf9791229:v130"); Mon, 21 Nov 2022 14:05:09 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: ed9ebb154581436a X-CR-MTA-TID: 64aa7808 Received: from a8cafe6e59d7.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id 93463734-4903-4FD9-95CD-20B4428149BB.1; Mon, 21 Nov 2022 14:05:02 +0000 Received: from EUR01-HE1-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id a8cafe6e59d7.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Mon, 21 Nov 2022 14:05:02 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=f4rj0p38pS1Sxk3qxPngs+0Fh1kYSKgJ7/lXvg+GvfhQYU2tvsN9dYRRfK+l0s3xnk9Jz7733ZfVHvev809W1Eb+F5z1nbq6P4dnMRy+l8G9kjZmJGmnVBnBd448dl6vHsAKsFKJ+vDDM8qEMNSJBpInhaHMulAgebK1fk0ADZmICKjcAnqgidIDi/VOpKC2y1fVmfT3B18UpBBfNQGEmgvDXHfeOznw60lGsLGf1tckZ8j6szJWY8Qgwm0LOlns5IRV+efqH5n3GsAMlJzXGP2PGLF4Cdbf4axvr2OrYDa/tXFCf/b8H+RWv2Y1ENyacmJCdJ0cOfjDe3DIbPNHrg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NGif+Ejy8+OFQ5yug/KcaXv+yoEwwSD0VM9/Y1iPAfw=; b=Z47WfEyEIahyMXgDaQdmyfS1Qk5znTg0ZMTlUkAEXZ4vh+DkaogLQnGzaE6e68u/mS+VfFUIF6biiFqcGYEesidDjhlU4k45U0zaubFQOceC6pM6I8JJ3/fZA4RnDEORBQ/DIe4xI8Iqjk/FzvRenymVCINwsR1CEvQSc2R5pZMtSu3jZBI/hD9Clyf58+1hM/X0dFSyD3ApTcg0+S4SjyED2URQXXMKC1hqlWCDCu5b59ux5W5j5uE0L8DAoblVFQuJfwIANwSIH1TL+msRGcwuDAIyWcVYJSZ65ke3ZvuvUfLTksj0Oh3NVa2zbMh9Srlab19gAkI8gq3UYYog0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NGif+Ejy8+OFQ5yug/KcaXv+yoEwwSD0VM9/Y1iPAfw=; b=xVpstgDGTDBaL6Rfqq/fUrAm3tTzNPM/iD7tPXsc5GQV05VeuLO58HXq/K2pENkkcF/7AFpySH8Y5qmWPHNGNwqkFLMHSN5eZzgcvhkZ0EfQ+pDHQ5VaRoIq28F7Q9NaeQoDXDcLIpaaD830c6ndsYArjSD3VpFFIoBK96Kd0bc= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by AS8PR08MB9816.eurprd08.prod.outlook.com (2603:10a6:20b:613::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.13; Mon, 21 Nov 2022 14:04:59 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c470:cc90:a9ad:6dd1]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::c470:cc90:a9ad:6dd1%4]) with mapi id 15.20.5857.017; Mon, 21 Nov 2022 14:04:59 +0000 Message-ID: <27b65d2b-1c4b-191c-2771-5644eb2687e4@arm.com> Date: Mon, 21 Nov 2022 14:04:57 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v2 1/4] gdb/arm: Update active msp/psp when switching stack To: =?UTF-8?Q?Torbj=c3=b6rn_SVENSSON?= , gdb-patches@sourceware.org Cc: vanekt@volny.cz References: <20221118155252.113476-1-torbjorn.svensson@foss.st.com> <20221118155252.113476-2-torbjorn.svensson@foss.st.com> Content-Language: en-US From: Luis Machado In-Reply-To: <20221118155252.113476-2-torbjorn.svensson@foss.st.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0316.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:197::15) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|AS8PR08MB9816:EE_|AM7EUR03FT032:EE_|DB9PR08MB8360:EE_ X-MS-Office365-Filtering-Correlation-Id: 3a0aee4f-b581-4321-0577-08dacbc966b7 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dV44PSXCD3/NXrfSM7Ykk8i/bAnAXHmj5JkU5lhBTT6udOglIO32sEq3D8sQgOWGqLeiZoRDggnsV6DG9s4A1qs9kyejC8dmrMpv5uDD2V6QYoiRH1UVlxX6U2jD0dSNZxRa5mY0Adk6x2XYukeuHRJFqi+V+CJj52r+crI8X5zFgdUC3Y5/m86ET+Xk0EWH0/4k0CLm2gT4z5NrJzO3GlTDuBIrwZtHN5HrhjEBb+1fd0oDUpeQstxnf9Czgj+DNZfq4UmKFW2n6wOletnNMZLAyncBc8ZSKeB6Tt7DTTOA84jywiizKtg0VeOy6kihgi2+Ach/p8pRjvClTipQXb5DkMLQ4vqGtsKL+5DQKh8PYuaQp971BkmnbnKUhlHRwkkp2z3OEULUb3Jvk1GPsOwEyaO3/qVwaEg/GkwpEfvYL29vxqemjyUtJqZ/qULgA2opY1kIxM0yzEUJlTBQs2bGSL6PyAaXIOBLMg42tuKNnfIyBX+Dik85orNqYf/2YFu5HNuWKhmAzhdLsOMnNDt3AKIXB5KXUeDE53i7UvYocxgj3TIm+FgL7pXrpF9bN9LHadVDfSg4CntnNPRmW7MXV0+bpCGTnqetYWp2tgu8VcEs6dH2NcXUehEcnDrmFjxyDRX/vuWkLW6bM+RrKLLfHoGni6LUdwjonHVgWrqwiMtwVZhjHQwODpB72IHXJRhN+iZDsmq+g/aBDrPntTCod7hxK3IVswAgX2P6mgg= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:VI1PR08MB3919.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(4636009)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199015)(316002)(26005)(8936002)(186003)(36756003)(15650500001)(44832011)(5660300002)(6512007)(83380400001)(2906002)(66574015)(66556008)(66476007)(66946007)(2616005)(4326008)(8676002)(41300700001)(31686004)(6486002)(6506007)(478600001)(31696002)(86362001)(38100700002)(53546011)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR08MB9816 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: e5fa4433-13d3-4bc2-27fe-08dacbc9603a X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yTPqoD6/61MjGorrBgF+zCfex77xtxDSj0cgu9HysU/vhDmcIlF4M8pF73ziGEEKTCHhdtzzLTC1V7FewqtChUVIaXDXrWj2IvuJm/mKQL3ng/UVZUpsaTim/row+1sD3WvcO3kc6vvcbd8zJmyj1ivN2mkgARVhMqUkd5jeo2Qu9hXNOHcPRiw7nikHKrue3izFhhgTGv8B6V270ZJN7ja76ONPVrlz79d0+532R23Lj9rSofy6C80jV2kwgcw69/RdcLGitYdYlPP5amqTbyeGJM8qaS5U8YJvaydehiOEYbDdnhDOv5nI30DOzy5lOfjgzmBgdK/zZ2yguoJgt45n4PTvpFLVvB/m7ZxjwtNv22aqBQFlR7Vntwq3af47rrlv4QCWXBO+u9nTw2T5KMWRa/X6HAauEjVkJDNCDMe93C+HTHNKnbzsObe7hoSy53vCFCOlJhMlo/Utep4rg4HW3+8J93r295CXGZhW1Oi3HfpLRhViG0Q1Hl/5sSE5jYXk/qAsNe+EYCIWKMGSDdNKBNlNEuInzM28ThUxyC59tJLy0eNQikBZ3ixfMydpXAdyVgPW2813lC/JV/Ye4gj1ESrrZyZa6WadTZ0706aglfEzMKy9K3Y5qDRW0H7sFWM+hbk0mmuBvznLYv3Js5oORK8cei8sok+6KobEQGLGxGFWLtpvTVjLre34PvQSNJu5FMWQtLSvIZcpU9F/YfPB9kT7GwFXaoBWwmlCxaI= X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230022)(4636009)(39860400002)(346002)(376002)(136003)(396003)(451199015)(36840700001)(40470700004)(46966006)(40460700003)(36860700001)(81166007)(82740400003)(356005)(31696002)(86362001)(44832011)(5660300002)(41300700001)(8676002)(8936002)(70586007)(70206006)(4326008)(82310400005)(2906002)(15650500001)(47076005)(2616005)(186003)(107886003)(66574015)(53546011)(316002)(83380400001)(6512007)(336012)(6486002)(26005)(6506007)(478600001)(40480700001)(31686004)(36756003)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 14:05:09.7857 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3a0aee4f-b581-4321-0577-08dacbc966b7 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT032.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB8360 X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,FORGED_SPF_HELO,GIT_PATCH_0,KAM_DMARC_NONE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,TXREP,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 11/18/22 15:52, Torbjörn SVENSSON wrote: > For targets with secext, msp and psp can be seen as an alias for one > of msp_s, msp_ns, psp_s or psp_ns. When switching active sp, the > coresponding msp/psp needs to be switched too. coresponding -> corresponding. > > Signed-off-by: Torbjörn SVENSSON > --- > gdb/arm-tdep.c | 19 +++++++++++++++++-- > 1 file changed, 17 insertions(+), 2 deletions(-) > > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 7cb3f5f3050..124a94dc87d 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -504,8 +504,23 @@ arm_cache_switch_prev_sp (struct arm_prologue_cache *cache, > gdb_assert (arm_is_alternative_sp_register (tdep, sp_regnum)); > > if (tdep->have_sec_ext) > - gdb_assert (sp_regnum != tdep->m_profile_msp_regnum > - && sp_regnum != tdep->m_profile_psp_regnum); > + { > + gdb_assert (sp_regnum != tdep->m_profile_msp_regnum > + && sp_regnum != tdep->m_profile_psp_regnum); > + > + if (sp_regnum == tdep->m_profile_msp_s_regnum > + || sp_regnum == tdep->m_profile_psp_s_regnum) > + { > + cache->active_msp_regnum = tdep->m_profile_msp_s_regnum; > + cache->active_psp_regnum = tdep->m_profile_psp_s_regnum; > + } > + else if (sp_regnum == tdep->m_profile_msp_ns_regnum > + || sp_regnum == tdep->m_profile_psp_ns_regnum) > + { > + cache->active_msp_regnum = tdep->m_profile_msp_ns_regnum; > + cache->active_psp_regnum = tdep->m_profile_psp_ns_regnum; > + } > + } > > cache->active_sp_regnum = sp_regnum; > } This is OK with the commit message adjusted. Thanks, Luis