From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 14E503858CDA for ; Fri, 3 Nov 2023 03:40:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 14E503858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 14E503858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698982867; cv=none; b=s4JHrAGPPzu7Iq1TClpug1ATOhAlnqeyE5Cr0ViHCPtex/O1fNClpVFxENkYWuk+iZx55VS0oTE9yhNA9gV9YW11lT+NqfZXtp+soP7pPrJL6kpKcOX1LtWAbccMLzfOG+QjdsnZubsXxDZOpUH/D0TtyWUNeTSpVRXdkOwUa9k= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1698982867; c=relaxed/simple; bh=tPaZciU1XDSry6hSj7/63YY0DV8WIkjCSSVPjLk/qwg=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=bni+PCokMzbMgasroJfLKayRl78mx6tgVFPKI/hWz2X5y3p1liPcGvMbcEF7bRvaexAHy4Et3ukwYHUzrXJ6r3Cw7l0esegQhwfFEdfXNuWW69Zacv9igrzI4ygrQ0JPhSzo1D3yOo043KoEddRQtdEHtCLs4qIcW+Dv8cl5atY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1698982856; bh=tPaZciU1XDSry6hSj7/63YY0DV8WIkjCSSVPjLk/qwg=; h=Date:Subject:To:References:From:In-Reply-To:From; b=rj3kNFxIlgC/L63I7ylVkwXQWfHSIypqWqq2TygpoZquVrXbncWZ7ba1yGQmlHYYi 08dpPx4sj7ob3hRpzeXP8es78KcOqu7s2BqzXwOvJ2rI0ntkbYWrsLXGKMq+EZp9pm 1IXAA3w8ulyYWa+rEMZvZP0rV7TlJ8C3RJLMoDLI= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 458651E0C1; Thu, 2 Nov 2023 23:40:56 -0400 (EDT) Message-ID: <27cfe94f-cabe-4260-af43-2244f4472e81@simark.ca> Date: Thu, 2 Nov 2023 23:40:55 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/30] Use block_symbol::address in ada-tasks.c To: Tom Tromey , gdb-patches@sourceware.org References: <20231029-split-objfile-2023-bound-sym-october-v1-0-612531df2734@tromey.com> <20231029-split-objfile-2023-bound-sym-october-v1-4-612531df2734@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20231029-split-objfile-2023-bound-sym-october-v1-4-612531df2734@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-10-29 19:23, Tom Tromey wrote: > This changes ada-tasks.c to use block_symbol::address. > --- > gdb/ada-tasks.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/gdb/ada-tasks.c b/gdb/ada-tasks.c > index 047566e6228..9f2d670e71e 100644 > --- a/gdb/ada-tasks.c > +++ b/gdb/ada-tasks.c > @@ -914,7 +914,7 @@ static void > ada_tasks_inferior_data_sniffer (struct ada_tasks_inferior_data *data) > { > struct bound_minimal_symbol msym; > - struct symbol *sym; > + struct block_symbol sym; I'd suggest declaring separate sym variables in the two scopes where it's needed (ideally where it's initialized). This helps show that the two uses are not related and specific to those scopes. Simon