From: Tom de Vries <tdevries@suse.de>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb] Remove trailing "done" after "Reading symbols from" message
Date: Fri, 06 Mar 2020 11:56:00 -0000 [thread overview]
Message-ID: <27dd2b99-f822-5d72-c1ec-254fe3d7f2a6@suse.de> (raw)
In-Reply-To: <20200306110211.GC3317@embecosm.com>
On 06-03-2020 12:02, Andrew Burgess wrote:
> * Tom de Vries <tdevries@suse.de> [2020-03-04 15:13:08 +0100]:
>
>> On 04-03-2020 15:07, Andrew Burgess wrote:
>>> * Tom de Vries <tdevries@suse.de> [2020-03-04 14:21:34 +0100]:
>>>
>>>> Hi,
>>>>
>>>> Using verbose, we get some detail on symbol loading:
>>>> ...
>>>> $ gdb a.out -iex "set verbose on"
>>>> Reading symbols from a.out...
>>>> Reading in symbols for /home/vries/hello.c...done.
>>>> (gdb)
>>>> ...
>>>>
>>>> And using debug symtab-create, much more detail:
>>>> ...
>>>> $ gdb a.out -iex "set verbose on" -iex "set debug symtab-create 1"
>>>> Reading symbols from a.out...
>>>> Reading minimal symbols of objfile /data/gdb_versions/devel/lto/a.out ...
>>>> Installing 30 minimal symbols of objfile /data/gdb_versions/devel/lto/a.out.
>>>> Done reading minimal symbols.
>>>> Creating one or more psymtabs for objfile /data/gdb_versions/devel/lto/a.out ...
>>>> Created psymtab 0x35a3de0 for module ../sysdeps/x86_64/start.S.
>>>> Created psymtab 0x353e4e0 for module init.c.
>>>> Created psymtab 0x353e560 for module ../sysdeps/x86_64/crti.S.
>>>> Created psymtab 0x353e5e0 for module /home/vries/hello.c.
>>>> Created psymtab 0x35bd530 for module elf-init.c.
>>>> Created psymtab 0x35bd5b0 for module ../sysdeps/x86_64/crtn.S.
>>>> Reading in symbols for /home/vries/hello.c...Created compunit symtab 0x354bd20 for hello.c.
>>>> done.
>>>> (gdb)
>>>
>>> I'm struggling to understand what problem you're trying to solve
>>> here. In general, if we switch on any of the 'set debug ...' flags
>>> the output from GDB gets confused. These flags aren't intended for
>>> general use, and trying to "fix" GDB's output in the face of these
>>> flags is going to be a huge task, for I'm not sure what benefit.
>>>
>>> Other than the output looking a little neater, is there an actual
>>> problem solved here?
>>
>> This patch is intended to make the output look a little neater.
>
> Oh, yeah, sorry, I miss-read the original patch description. I'm fine
> with this.
>
Np, thanks for the review :)
- Tom
prev parent reply other threads:[~2020-03-06 11:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 13:21 Tom de Vries
2020-03-04 14:08 ` Andrew Burgess
2020-03-04 14:13 ` Tom de Vries
2020-03-06 11:02 ` Andrew Burgess
2020-03-06 11:56 ` Tom de Vries [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27dd2b99-f822-5d72-c1ec-254fe3d7f2a6@suse.de \
--to=tdevries@suse.de \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).