From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 5F62E3854818 for ; Sun, 4 Oct 2020 01:59:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F62E3854818 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 630671E965; Sat, 3 Oct 2020 21:59:39 -0400 (EDT) Subject: Re: [PATCH] Make range types inherit signed-ness from base type To: Tom Tromey , gdb-patches@sourceware.org References: <20200822210711.28361-1-tom@tromey.com> From: Simon Marchi Message-ID: <28055f84-c81a-9e13-2719-fe3aea8313ff@simark.ca> Date: Sat, 3 Oct 2020 21:59:38 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20200822210711.28361-1-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Oct 2020 01:59:46 -0000 On 2020-08-22 5:07 p.m., Tom Tromey wrote: > I ran across this comment in valprint.c: > > /* FIXME: create_static_range_type does not set the unsigned bit in a > range type (I think it probably should copy it from the target > type), so we won't print values which are too large to > fit in a signed integer correctly. */ > > It seems to me that a range type ought to inherit its signed-ness from > the underlying type, so this patch implements this change, and removes > the comment. (It was also copied into m2-valprint.c.) > > I also remove the comment about handling ranges of enums, because I > think that comment is incorrect. This looks OK to me, although I have to admit I don't really understand the impact. Simon