From: Pedro Alves <palves@redhat.com>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: Re: [PATCH 6/8] Add push_target overload
Date: Thu, 07 Feb 2019 17:23:00 -0000 [thread overview]
Message-ID: <2860385b-5994-4e4c-8010-35fd347b7d03@redhat.com> (raw)
In-Reply-To: <20190207094016.368-7-tom@tromey.com>
On 02/07/2019 09:40 AM, Tom Tromey wrote:
> From: Tom Tromey <tromey@adacore.com>
>
> This adds a push_target overload that takes a "target_ops_up &&".
> This removes some calls to release a target_ops_up, and makes the
> intent here clearer.
I like it.
Thanks,
Pedro Alves
next prev parent reply other threads:[~2019-02-07 17:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 14:22 [PATCH 0/8] Clean up ravenscar-thread.c Tom Tromey
2019-02-07 9:40 ` [PATCH 3/8] C++-ify ravenscar_arch_ops Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-11 18:56 ` Tom Tromey
2019-02-07 9:40 ` [PATCH 2/8] Exception safety in ravenscar-thread.c Tom Tromey
2019-02-07 9:40 ` [PATCH 8/8] Special-case wildcard requests " Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-09 4:41 ` Joel Brobecker
2019-02-14 13:35 ` Pedro Alves
2019-02-15 20:43 ` Tom Tromey
2019-02-15 20:39 ` Tom Tromey
2019-02-20 19:23 ` Pedro Alves
2019-02-07 9:40 ` [PATCH 7/8] Make the ravenscar thread target multi-target-ready Tom Tromey
2019-02-07 17:23 ` Pedro Alves
2019-02-07 9:40 ` [PATCH 4/8] Fix formatting in ravenscar-thread.c Tom Tromey
2019-02-07 9:40 ` [PATCH 5/8] Minor C++-ification " Tom Tromey
2019-02-07 9:40 ` [PATCH 6/8] Add push_target overload Tom Tromey
2019-02-07 17:23 ` Pedro Alves [this message]
2019-02-07 14:22 ` [PATCH 1/8] Fix some typos in ravenscar-thread.c Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2860385b-5994-4e4c-8010-35fd347b7d03@redhat.com \
--to=palves@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).