From: Paul Hilfinger <hilfingr@tully.CS.Berkeley.EDU>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: Paul Hilfinger <Hilfinger@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [RFA] Have block_innermost_frame start from selected frame
Date: Thu, 29 Dec 2011 20:30:00 -0000 [thread overview]
Message-ID: <28663.1325185294@tully.CS.Berkeley.EDU> (raw)
In-Reply-To: <20111228130130.GA1855@host2.jankratochvil.net>
> In such case the doc should be updated, particularly that it has became now
> related to the currently selected frame.
Will do.
> It may be all even more tricky than it was before. What about using query()
> if such reference is ambiguous?
>
> It may not be so easy determining the ambiguity. Something like checking
> symbol_read_needs_frame() and then also checking if there exist >= 2 different
> frames containing the block.
I understand the argument here, but I'm not sure I can agree. The
ambiguity you speak of already occurs with high frequency, after all,
since when I say
print x
there may be many local x's lying around, both recursive instances of the same
definition or instances of unrelated definitions. Programmers are
expected to understand this and already have a mechanism for specifying
which they mean (up/frame/down). It is a very common situation
(especially for someone like me who is always playing around with
compilers in which a significant percentage of calls are recursive). I
am inclined to think, therefore, that warnings would not be considered helpful.
> And the comment of this function is no longer valid then:
>
> /* Return the innermost stack frame executing inside of BLOCK, or NULL
> if there is no such frame. If BLOCK is NULL, just return NULL. */
>
> struct frame_info *
> block_innermost_frame (const struct block *block)
Good point. In fact, do you think we should change the function name?
The frame is no longer "innermost", after all.
Paul Hilfinger
next prev parent reply other threads:[~2011-12-29 19:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-27 19:59 Paul Hilfinger
2011-12-28 13:10 ` Jan Kratochvil
2011-12-28 15:41 ` Joel Brobecker
2011-12-28 16:00 ` Jan Kratochvil
2011-12-28 17:23 ` Joel Brobecker
2011-12-29 20:30 ` Paul Hilfinger [this message]
2011-12-29 23:13 ` Jan Kratochvil
2011-12-28 15:16 ` Jan Kratochvil
2011-12-30 21:54 Paul Hilfinger
2011-12-31 8:58 ` Eli Zaretskii
2011-12-31 21:40 ` Paul Hilfinger
2012-01-09 7:17 ` Paul Hilfinger
2012-01-09 17:14 ` Eli Zaretskii
2012-01-09 19:59 ` Paul Hilfinger
2012-01-10 5:21 ` Joel Brobecker
2012-01-10 10:28 ` Eli Zaretskii
2012-01-10 10:40 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28663.1325185294@tully.CS.Berkeley.EDU \
--to=hilfingr@tully.cs.berkeley.edu \
--cc=Hilfinger@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).