From: Simon Marchi <simon.marchi@polymtl.ca>
To: Lancelot SIX <lsix@lancelotsix.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH v4 4/4] gdb: Setting setter return a bool to tell if the value changed
Date: Thu, 30 Sep 2021 08:43:23 -0400 [thread overview]
Message-ID: <2867ca83-607a-7708-037c-b293086215ed@polymtl.ca> (raw)
In-Reply-To: <20210929215011.1489639-5-lsix@lancelotsix.com>
> diff --git a/gdb/command.h b/gdb/command.h
> index 5ab25c74a9f..2d4561318bc 100644
> --- a/gdb/command.h
> +++ b/gdb/command.h
> @@ -315,12 +315,14 @@ struct setting
>
> The var_type of the setting must match T. */
> template<typename T>
> - void set (const T &v)
> + bool set (const T &v)
Can you just update the comment to document the return value meaning?
LGTM otherwise.
Simon
next prev parent reply other threads:[~2021-09-30 12:44 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-29 21:50 [PATCH v4 0/4] Refactor cmd_list_element.var Lancelot SIX
2021-09-29 21:50 ` [PATCH v4 1/4] gdb: Introduce setting construct within cmd_list_element Lancelot SIX
2021-09-30 12:12 ` Simon Marchi
2021-09-30 12:30 ` Simon Marchi
2021-09-30 23:15 ` Lancelot SIX
2021-10-01 1:16 ` Simon Marchi
2021-09-30 12:39 ` Simon Marchi
2021-09-29 21:50 ` [PATCH v4 2/4] gdb: make string-like set show commands use std::string variable Lancelot SIX
2021-09-29 21:50 ` [PATCH v4 3/4] gdb: Have setter and getter callbacks for settings Lancelot SIX
2021-09-30 12:42 ` Simon Marchi
2021-10-05 19:10 ` Simon Marchi
2021-10-05 20:27 ` Lancelot SIX
2021-10-05 20:39 ` Simon Marchi
2021-10-05 22:21 ` Lancelot SIX
2021-09-29 21:50 ` [PATCH v4 4/4] gdb: Setting setter return a bool to tell if the value changed Lancelot SIX
2021-09-30 12:43 ` Simon Marchi [this message]
2021-09-30 12:44 ` [PATCH v4 0/4] Refactor cmd_list_element.var Simon Marchi
2021-10-03 19:22 ` Lancelot SIX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2867ca83-607a-7708-037c-b293086215ed@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).