Re: [PATCH] Powerpc: Add support for openat and fstatat syscalls

[Carl Love <cel@us.ibm.com>]

Ulrich:

On Thu, 2021-10-07 at 19:52 +0200, Ulrich Weigand wrote:
> "Carl Love" <cel@us.ibm.com> wrote on 05.10.2021 22:59:06:
> 
> > +  else if (syscall == 286)
> > +    result = gdb_sys_openat;
> 
> This looks OK, but ...
> 
> > +  else if (syscall == 291)
> > +    result = gdb_sys_fstatat64;
> 
> syscall 291 is actually different between 32-bit
> and 64-bit: on 32-bit it is fstatat64, but on
> 64-bit it is newfstatat.
> 
> Given that this routine seems to be used for
> both flavors, it should be correct for both.
> 
> (Also, there seem to be many more syscalls that
> are not handled even though they could be.  But
> that can be left for another time I guess ...)

I changed the fstatat64 to newfstat.  I re-ran the regression tests on
a Power 9 system.  The patch does seem to work correctly.  Don't have a
32-bit system to verify on.

Please let me know if the patch below looks acceptable.  Thanks.

                       Carl 

-------------------------------------------------------
Powerpc: Add support for openat and fstatat syscalls

[gdb] update ppc-linux-tdep.c

Add else if syscall entries for the openat and fstatat system calls.
---
 gdb/ppc-linux-tdep.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c
index 1e94922f25a..895dacd7c1b 100644
--- a/gdb/ppc-linux-tdep.c
+++ b/gdb/ppc-linux-tdep.c
@@ -1391,6 +1391,10 @@ ppc_canonicalize_syscall (int syscall)
     result = syscall += 259 - 240;
   else if (syscall >= 250 && syscall <= 251)	/* tgkill */
     result = syscall + 270 - 250;
+  else if (syscall == 286)
+    result = gdb_sys_openat;
+  else if (syscall == 291)
+    result = gdb_sys_newfstatat;
   else if (syscall == 336)
     result = gdb_sys_recv;
   else if (syscall == 337)
-- 
2.25.1