From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 7B72C3858D28 for ; Tue, 29 Aug 2023 12:28:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7B72C3858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1693312138; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZE7lZKzCHXEs4odIxag/E3XNWsS2/q7k7GwxE//fU28=; b=a7W/xG6pDA0SGl/v4TkpSnbILFwU09amLNdVIh6Yx7ChN49zp+PwvNHe4MhftA6FydPvRD 2VpZgOEx8wbdUwnPtgQsGdlghyY15BmaOiI2nzM3EUF+e8zHAhtgwByF5+wbMomCuNtM51 CZPI52+r1QBiE1GSuTUovOZ3ERoxTrM= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-587-8DKh86D8M3yPWaSnYMuT2g-1; Tue, 29 Aug 2023 08:28:56 -0400 X-MC-Unique: 8DKh86D8M3yPWaSnYMuT2g-1 Received: by mail-ej1-f72.google.com with SMTP id a640c23a62f3a-99beea69484so328413166b.0 for ; Tue, 29 Aug 2023 05:28:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693312135; x=1693916935; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZE7lZKzCHXEs4odIxag/E3XNWsS2/q7k7GwxE//fU28=; b=gR0zpjNK12JI2Uy+zGpTEgjx+rtBS3cH9aezYAzud/w48SboXCXmcjtt6rGw2q8beU 36ECTnCVQ7ANpxjP0Bqqpgut1ehdUowzM9I5hv6C1ESv83LXSdZo4hMGXWxd8h2hdhD5 4YuxbxCzWn8PQsVoTohTpvlYEZfO+wNmrWi+UWt5KHFz9ceMDY2+yZSHR1En6527TUMk Vwn21NBTYcpmSGku5szDn9NGoI6QYT4a2YERYfmtlesCGBIml36dLKp5PNpAYpjet9Dv uJaczt0EqHtR7VBdsNNXDMarV6SVNRDRaGqWbW9wEV2jUHJtArEbIoGJAEMFMzKv6d4i 9QVw== X-Gm-Message-State: AOJu0YxlG1VzD+li9I8q0r8mqZqn+SgQNRY/4YwUr5p3n1Wq5YmJEuUd HnJuh75yueBjJZ52f6QFkVvexqI287hj6KstI/+FhrdxieT3S4rxxkHnpbf1v6goDnkQ2+85ehc UflE/vx1dfXjbDyGT3BUiHgx1adzOLg== X-Received: by 2002:a17:907:2bdf:b0:9a2:eb6e:2cf1 with SMTP id gv31-20020a1709072bdf00b009a2eb6e2cf1mr9419377ejc.5.1693312135665; Tue, 29 Aug 2023 05:28:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFVeYziz5l5t45KSR0/pMnzx1jpm4x4VBXTis4/v6qbM92JsH8VWsr03tmyLGSfmM34Is8Q+Q== X-Received: by 2002:a17:907:2bdf:b0:9a2:eb6e:2cf1 with SMTP id gv31-20020a1709072bdf00b009a2eb6e2cf1mr9419371ejc.5.1693312135433; Tue, 29 Aug 2023 05:28:55 -0700 (PDT) Received: from [192.168.0.129] (ip-94-112-225-44.bb.vodafone.cz. [94.112.225.44]) by smtp.gmail.com with ESMTPSA id h1-20020a1709062dc100b0099bd046170fsm5847550eji.104.2023.08.29.05.28.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Aug 2023 05:28:54 -0700 (PDT) Message-ID: <28ab7382-a91a-1ed1-de18-c695ae3669d4@redhat.com> Date: Tue, 29 Aug 2023 14:28:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 0/2] Fix reverse stepping multiple contiguous PC ranges over the line table. To: Carl Love , Simon Marchi , gdb-patches@sourceware.org, UlrichWeigand , pedro@palves.net Cc: luis.machado@arm.com References: <6d10baef346804f88821dd36cd8ab1aac3bf210a.camel@us.ibm.com> From: Guinevere Larsen In-Reply-To: <6d10baef346804f88821dd36cd8ab1aac3bf210a.camel@us.ibm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_BARRACUDACENTRAL,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 25/08/2023 17:50, Carl Love wrote: > GDB maintainers: > > I received a few messages from Guinevere about these two patches. In > the end, we agreed the first patch was OK. There was a minor code > change suggested for the second patch that I have implemented. Since I > have not received any additional suggestions on the second patch, it is > time to ping the first patch and post the updated second patch for > review. > > The first patch in the series has not been changed. I am reposting it > along with the second patch so it doesn't get lost. > > The patch series has been tested on Power10 LE and on X86-64. > > Please let me know if these two patches are acceptable for mainline. > Thanks. > > Carl > I have tested this patch with both GCC and Clang. I can verify it fixes the issue, adds no regression, and even fixes the final issues when testing gdb.reverse with clang! Tested-By: Guinevere Larsen -- Cheers, Guinevere Larsen She/Her/Hers