From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 9387A3858C52 for ; Fri, 15 Sep 2023 15:43:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9387A3858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 38FFfn1p001419 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 15 Sep 2023 11:41:54 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 38FFfn1p001419 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1694792514; bh=Kz4r5FMhVi48mMesLHS1q1CiL8KONI3fCbLOYwOlmyM=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=SJIpzCkxruyvlC4TpXazW6WfMN5z1LV9L1FdRBagc61SFbxI74Dm4c7zyDn1p8tc+ bEIzkBtWNagRFaf0B+ApTDhWqdFZmuGcZCsa9Ls4HN61NM6GukY1O+LiVfnEIihcj5 EbIebg+F3szM1pbG5KFiGjgOaiJ9g+Re2SyMslf8= Received: from [172.16.0.192] (192-222-143-198.qc.cable.ebox.net [192.222.143.198]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B9DAB1E028; Fri, 15 Sep 2023 11:41:48 -0400 (EDT) Message-ID: <28ec3678-277d-4327-98e2-e9ab1427b9fa@polymtl.ca> Date: Fri, 15 Sep 2023 11:41:48 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/amdgpu: Silence wave termination messages Content-Language: fr To: Lancelot Six , gdb-patches@sourceware.org Cc: lsix@lancelotsix.com, Laurent Morichetti References: <20230915105243.3377965-1-lancelot.six@amd.com> From: Simon Marchi In-Reply-To: <20230915105243.3377965-1-lancelot.six@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 15 Sep 2023 15:41:49 +0000 X-Spam-Status: No, score=-3037.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 9/15/23 06:52, Lancelot Six via Gdb-patches wrote: > From: Laurent Morichetti > > Hi, > > Here is a patch originally written by Laurent Morichetti fixing a > regression in the amd-dbgapi-target I am submitting on his behalf. > > Best, > Lancelot. > > After commit 9d7d58e7262, the amdgpu target started printing > "thread exited" messages when pruning waves that had terminated. > > ... > [AMDGPU Wave ?:?:?:2045 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2046 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2047 (?,?,?)/? exited] > [AMDGPU Wave ?:?:?:2048 (?,?,?)/? exited] > ... > > The issue was that before commit 9d7d58e7262, delete_thread was silent > by default due to a bug that the commit fixed. > > Replaced the amdgpu target call to delete_thread with a call to > delete_thread_silent. > > Change-Id: Ie5d5a4c5be851f092d2315b2afa6a36a30a05245 > --- > gdb/amd-dbgapi-target.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 22c269b7992..8eafceac569 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -1634,7 +1634,7 @@ amd_dbgapi_target::update_thread_list () > auto it = threads.find (tp->ptid.tid ()); > > if (it == threads.end ()) > - delete_thread (tp); > + delete_thread_silent (tp); > else > threads.erase (it); > } > > base-commit: 38cc67cc00dc7385991e2658a1b4213d5ba3c4f0 > -- > 2.34.1 > LGTM, thanks. Approved-By: Simon Marchi Simon